allowed special characters in address field

[vaibhavarora102]

Description

allowed the special characters in the address field, using RegexValidator

Fixes #1037

Type of Change:

• Code
• Quality Assurance

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update (software upgrade on readme file)
• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I had tested on local setup and it works fine

Checklist:

Delete irrelevant options.

• [ ] I have performed a self-review of my own code or materials
• [ ] Any dependent changes have been merged

Code/Quality Assurance Only

• [ ] My changes generate no new warnings
• [ ] New and existing unit tests pass locally with my changes

[keshakaneria]

You might have removed the end new line in the file because of which this build is failing. Try adding a new at the end of file and push the commit again @vaibhavarora102

[vaibhavarora102]

I did not understand can you @keshakaneria please explain a bit as i think i had not removed anything

[keshakaneria]

I did not understand can you @keshakaneria please explain a bit as i think i had not removed anything

Just once in your editor if there is any newline at the end of this file. If No, then add a new blank line at the end of the file in which you have made changes.

[vaibhavarora102]

no, I checked there is an extra line at the end

[keshakaneria]

@Kajol-Kumari Can you let us know why this build is still failed?

[Kajol-Kumari]

Hey @keshakaneria @vaibhavarora102 The build is failing due to this test. You can get to know more about the error from here to here . As you have modified the address validation regex so you need to modify this test accordingly.

[keshakaneria]

Hey @keshakaneria @vaibhavarora102 The build is failing due to this test. You can get to know more about the error from here to here . As you have modified the address validation regex so you need to modify this test accordingly.

Thanks for this :) @vaibhavarora102 You can have a look here for solving this problem

[vaibhavarora102]

I think they are saying to correct the test and I guess this could be done by you Correct me if I am wrong

[keshakaneria]

I think they are saying to correct the test and I guess this could be done by you Correct me if I am wrong

The changes should be tested by you before pushing. Thus, when you will try to test the changes, this error will show up. Let me know if this error shows up in your local system.

[vaibhavarora102]

on local host it is working good kindly tell what next to do

[vaibhavarora102]

Hi any updates?

[keshakaneria]

Hi any updates?

Ahh... I'm sorry, I just skipped this issue to review. Can you send the the screenshot which shows that all the tests are passed when you try to run the tests locally?

[codecov[bot]]

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6fc528d). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1113   +/-   ##
==========================================
  Coverage           ?   87.18%           
==========================================
  Files              ?       85           
  Lines              ?     4057           
  Branches           ?      237           
==========================================
  Hits               ?     3537           
  Misses             ?      449           
  Partials           ?       71           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fc528d...b07c275. Read the comment docs.

[keshakaneria]

Include these suggested changes @vaibhavarora102

[vaibhavarora102]

I missed that comment Thanks for reminding I will surely do it by today

[vaibhavarora102]

kindly check @keshakaneria

[vaibhavarora102]

Hi @keshakaneria when will my pr got merged as I need to fill OSH form

[keshakaneria]

Hi @keshakaneria when will my pr got merged as I need to fill OSH form

Yes @vaibhavarora102. The number of PR opened which gets finally merged before or after evaluation will be counted. Since, this PR has ready-to-merge tag, it will be merged soon by maintainers. You can proceed to fill the form.

[vaibhavarora102]

Thanks

[vaibhavarora102]

Hi, @keshakaneria while squashing i am facing some problem can i create another pr and close this one in respect to this

[keshakaneria]

Hi, @keshakaneria while squashing i am facing some problem can i create another pr and close this one in respect to this

This is even failing the test jobDetails and EventDetails