anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

Step by step guide for beginners #1116

Open ankit-saraf opened 3 years ago

ankit-saraf commented 3 years ago

Description

Created BEGINNER_GUIDE.md file

Fixes #1111

Type of Change:

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6fc528d). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1116   +/-   ##
==========================================
  Coverage           ?   86.93%           
==========================================
  Files              ?       85           
  Lines              ?     4057           
  Branches           ?      237           
==========================================
  Hits               ?     3527           
  Misses             ?      458           
  Partials           ?       72           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fc528d...22dbb79. Read the comment docs.

vj-codes commented 3 years ago

@ankit-saraf hey the doc looks good now, can you please squash the commits then I can give a final look and approve

ankit-saraf commented 3 years ago

@ankit-saraf hey the doc looks good now, can you please squash the commits then I can give a final look and approve

@vj-codes Can u please tell me how to do that

vj-codes commented 3 years ago

@ankit-saraf Check this out https://gist.github.com/longtimeago/f7055aa4c3bba8a62197

ankit-saraf commented 3 years ago

@ankit-saraf Check this out https://gist.github.com/longtimeago/f7055aa4c3bba8a62197

Should i use git rebase -i upstream/master @vj-codes

vj-codes commented 3 years ago

@ankit-saraf yes , if you did git pull from master branch cc : @sanchibansal340 @keshakaneria while squashing commits we rebase from master branch right?Thanks!

keshakaneria commented 3 years ago

@ankit-saraf yes , if you did git pull from master branch cc : @sanchibansal340 @keshakaneria while squashing commits we rebase from master branch right?Thanks!

No, if the PR is sent from master branch then only we need to squash them in master branch. So the thing you should take care is use the branch where you were working from. You can read more this here. You can use git rebase - i HEAD~n where n is the number of commits you want to squash from the latest commits you have done.

ankit-saraf commented 3 years ago

Seems like I overwrote the changes that I did here on Github. Thank god before squashing I took backup :)

ankit-saraf commented 3 years ago

@vj-codes Pls review. I squashed all the commits.