anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

UI: Enhanced date selection by adding range of date selection #1119

Open decon-harsh opened 3 years ago

decon-harsh commented 3 years ago

Added maxDate and minDate in js function. Deleted activate ActivateDatepicker function. Added placeholders of end date and start date input tags.

Fixes #655

Type of Change:

Code/Quality Assurance Only

Mocks

first two third fourth

Test

Screenshot from 2020-09-25 20-47-45

How Has This Been Tested?

Manually

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

decon-harsh commented 3 years ago

Need to edit some test cases , I will check this!

decon-harsh commented 3 years ago

So this error is occuring due to date format ,

should I change all date format in test cases . Becuase I tried to change update date format in datepicker and its not working. it is working for m/d/Y format only.

Need some help @satya7289 .

decon-harsh commented 3 years ago

1 failure solved 2 errors still remaining working on it

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b58bc98). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1119   +/-   ##
==========================================
  Coverage           ?   87.14%           
==========================================
  Files              ?       85           
  Lines              ?     4060           
  Branches           ?      237           
==========================================
  Hits               ?     3538           
  Misses             ?      452           
  Partials           ?       70           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b58bc98...b495c0c. Read the comment docs.

decon-harsh commented 3 years ago

Solved please review

decon-harsh commented 3 years ago

@SanketDG Hey @Kajol-Kumari please review

Kajol-Kumari commented 3 years ago

@decon-harsh Thank you very much for your hard work. @SanketDG @satya7289 can you please review it as Codewise it's looking good to me.

decon-harsh commented 3 years ago

Please add some test cases to validate that the dates are in a range in between the start date of the event and the end date of the event.

Added please verify @satya7289