anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

Fix: Unable to locate element error #1065 #1126

Closed sanjibansg closed 3 years ago

sanjibansg commented 3 years ago

Description

Added the necessary Selenium explicit and implicit waits for automating the process without Travis CI failing for not locating elements.

Fixes #1065

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

All the Travis CI Checks passed after updating the code file.

Checklist:

Code/Quality Assurance Only

codecov[bot] commented 3 years ago

Codecov Report

Merging #1126 into develop will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
- Coverage    87.30%   87.20%   -0.10%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
- Hits          3542     3538       -4     
- Misses         445      448       +3     
- Partials        70       71       +1     
Impacted Files Coverage Δ
vms/event/views.py 77.63% <0.00%> (-1.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8a4ea7...9fde553. Read the comment docs.

sanjibansg commented 3 years ago

@satya7289 Changes made as per asked, Do have a look.

sanjibansg commented 3 years ago

Also, please remove extra lines from the changed code.

Closing this PR due to some problems, opened PR #1150 for solving the issue, do review that.