anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Bug: Toggle top margin on base page #1128

Open decon-harsh opened 3 years ago

decon-harsh commented 3 years ago

In mobile view the top margin of main container in vms/templates/base.html earlier was fixed . When the hamburger icon is clicked and navbar expands the main container then should not have a fixed top margin of 100px. Added onclick function to change margin . Fixes #1109

Type of Change:

Quality Assurance
User Interface

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)

Mocks

Screenshot from 2020-09-24 13-48-47

Before

Screenshot from 2020-09-09 00-58-10

After

Screenshot from 2020-09-24 13-48-52

How Has This Been Tested?

Manually

Checklist:

Delete irrelevant options.

[X] My PR follows the style guidelines of this project
[X] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

[X] My changes generate no new warnings
[X] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b58bc98). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1128   +/-   ##
==========================================
  Coverage           ?   87.28%           
==========================================
  Files              ?       85           
  Lines              ?     4057           
  Branches           ?      237           
==========================================
  Hits               ?     3541           
  Misses             ?      446           
  Partials           ?       70

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b58bc98...a183a03. Read the comment docs.

decon-harsh commented 3 years ago

@Kajol-Kumari Hey , I have a doubt regarding OSH event, Where can i DM you. I can't find you on Zulip. Thanks

Kajol-Kumari commented 3 years ago

@Kajol-Kumari Hey , I have a doubt regarding OSH event, Where can i DM you. I can't find you on Zulip. Thanks

Hey @decon-harsh you can ask it in the OSH stream of Zulip as anyone of us would be able to answer you there. And you want to tag me, my username is kajol kumari singh for zulip