anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Feat: Add Hide/show toggle feature for all password fields #1136

Open sanjibansg opened 3 years ago

sanjibansg commented 3 years ago

Description

Password toggle feature added to view the entered password to verify whether correct or not.

Fixes #1077

Type of Change:

Code
User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

[x] My changes generate no new warnings

How has this been tested

Feature GIF

Feature video

codecov[bot] commented 3 years ago

Codecov Report

Merging #1136 into develop will increase coverage by 0.36%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1136      +/-   ##
===========================================
+ Coverage    86.93%   87.30%   +0.36%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
+ Hits          3527     3542      +15     
+ Misses         458      445      -13     
+ Partials        72       70       -2

Impacted Files	Coverage Δ
vms/event/views.py	`79.32% <0.00%> (+1.68%)`	:arrow_up:
vms/shift/views.py	`63.60% <0.00%> (+2.20%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ab16d3...f0641ef. Read the comment docs.

sanjibansg commented 3 years ago

@kahanikaar please attach the mock/GIF of the feature in the PR description.

Screenshots of the feature added. Will this work? @Kajol-Kumari

satya7289 commented 3 years ago

@kahanikaar please update your description of the PR, Put the gif/ screenshot or video showing how this feature is working, in the How has this been tested section. Also, please follow the commit message guidelines otherwise, it would not get merge.(also squash multiple commits into the single commit)

sanjibansg commented 3 years ago

LGTM +1 Please squash the commits so that It can be taken forward for merging.

Squashed the commits and changed the commit message. Do review. @Kajol-Kumari @satya7289