Open decon-harsh opened 3 years ago
Thanks @keshakaneria for the help , Please have a look!
Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?
:exclamation: No coverage uploaded for pull request base (
develop@b58bc98
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #1141 +/- ##
==========================================
Coverage ? 87.08%
==========================================
Files ? 85
Lines ? 4057
Branches ? 237
==========================================
Hits ? 3533
Misses ? 453
Partials ? 71
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b58bc98...0c4db04. Read the comment docs.
Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?
I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡
Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?
I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡
I will. One more thing I saw an issue in backend-repo where the one who completed or took part in OSH has to write a blog about it . But i guess it is specifically for that repo . Can we do the same for vms? 😯
Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it?
I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡
I will. One more thing I saw an issue in backend-repo where the one who completed or took part in OSH has to write a blog about it . But i guess it is specifically for that repo . Can we do the same for vms? 😯
Yeah sure you can. Let me know the topic of your blog if you have one otherwise I will provide you one. Can you just link that issue of blog which you saw here?
https://github.com/anitab-org/mentorship-backend/issues/904
My blog will focus mainly about the early problems i faced during my first PR and the increase in my confidence after the first PR . I would love to mention how easy it is to take part in OSH when the maintainers are ready to help you giving their best. etc Something sort of this😄.
My blog will focus mainly about the early problems i faced during my first PR and the increase in my confidence after the first PR . I would love to mention how easy it is to take part in OSH when the maintainers are ready to help you giving their best. etc Something sort of this😄.
Here it is. Go for it.
@keshakaneria @sanchibansal340 This hasn't been reviewed yet!
Added toggling effect on buttons(nav tabs) in administrator/settings.html
Fixes #1134
Type of Change:
Mocks
How Has This Been Tested?
Manually
Checklist:
Code/Quality Assurance Only