anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Fix: Binary string in email verification #1154

Open decon-harsh opened 3 years ago

decon-harsh commented 3 years ago

The url's uid was a b string. Decoded the uid to string. Removed some flake8 errors.

Fixes #1061

Initial PR #1086

Type of Change:

Code
Quality Assurance

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)

Mocks

Screenshot from 2020-09-04 00-10-37

Screenshot from 2020-09-04 00-10-46

How Has This Been Tested?

Manually

Checklist:

[X] My PR follows the style guidelines of this project
[X] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

[X] My changes generate no new warnings

decon-harsh commented 3 years ago

@devkapilbansal Please check this!

codecov[bot] commented 3 years ago

Codecov Report

Merging #1154 into develop will increase coverage by 0.24%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1154      +/-   ##
===========================================
+ Coverage    86.93%   87.18%   +0.24%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
+ Hits          3527     3537      +10     
+ Misses         458      448      -10     
  Partials        72       72

Impacted Files	Coverage Δ
vms/registration/views.py	`82.35% <0.00%> (+3.20%)`	:arrow_up:
vms/event/views.py	`79.32% <0.00%> (+1.68%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb63dfd...266a634. Read the comment docs.

decon-harsh commented 3 years ago

Thanks for your precious time @devkapilbansal . I guess i have nothing to change in this PR now? .

Please keep this PR in mind while reviewing OSH works.

devkapilbansal commented 3 years ago

Although this PR is same as the older one, but pinging @SanketDG @satya7289 @isabelcosta to look into this too

isabelcosta commented 3 years ago

@devkapilbansal thank you for the ping!

decon-harsh commented 3 years ago

When will it get merged? @devkapilbansal

devkapilbansal commented 3 years ago

@decon-harsh consider asking for review on Zulip. After two approved reviews and testing, this PR can be merged.