aniyomiorg / aniyomi

An app for manga and anime
https://aniyomi.org
Apache License 2.0
4.91k stars 317 forks source link

Invalid Image Due to & Character in DataSaver.kt (Line 84) #1319

Closed Afam007 closed 3 months ago

Afam007 commented 8 months ago

Steps to reproduce

  1. Use any extension that has Image Urls containing the & character with the bandwidthhero data saver in the reader

Expected behavior

The & character in the image Url should be encoded and not used with the bandwidth hero request as an additional parameter In the file DataSaver.kt, at line 84,

Actual behavior

The & character in the $imageUrl variable is used as an additional parameter to the bandwidthhero server, causing an invalid image

Crash logs

No response

Aniyomi version

App version: 0.15.2.2-7473

Android version

Android 12

Device

Samsung m11

Other details

No response

Acknowledgements

Afam007 commented 5 months ago

@jmir1 🥲🥲🥲

jmir1 commented 3 months ago

https://github.com/aniyomiorg/aniyomi/commit/39ba4324e2d0283d87e7d6b84b91e4846fa3639c