aniyomiorg / aniyomi

An app for manga and anime
https://aniyomi.org
Apache License 2.0
5.12k stars 319 forks source link

Subtitles are not offset when crop to fit option is used #1324

Closed Nek-12 closed 4 months ago

Nek-12 commented 10 months ago

Steps to reproduce

  1. Open a sub stream
  2. Select "cropped to screen"

Expected behavior

Subtitles are offset by crop amount to be visible

Actual behavior

Subtitles are cut because they are positioned for the uncropped stream

Crash logs

No response

Aniyomi version

0.15.2.2

Android version

14

Device

OnePlus 11

Other details

There is also no option to specify subtitle offset manually in sub settings

Acknowledgements

jmir1 commented 10 months ago

for my own reference: https://github.com/mpv-player/mpv/issues/11714

jmir1 commented 4 months ago

I added some options that achieve this for subtitle tracks that aren't in the ASS format: https://github.com/aniyomiorg/aniyomi/commit/02c5672d29887ce6b5f2214778417f42675c179c If you want the same behaviour for ASS subtitles, you need to enable "Override ASS subtitles" here: grafik