Make it harder to remove from library

mm12 commented 7 months ago

Describe your suggested feature

It should be more difficult to remove an entry from your library. Tapping the heart immediately removes it. Here are a few ways this can be improved: 1a) Switch long and short tap behaviors - short tap to change categories, long to remove. However, this may be a learning curve for long-time users. Rather, 1b) Make the heart only change the categories, but add a button to delete from library. 2) Add a 'are you sure' prompt 3) Adopt the menu from deleting on the library view - ask whether to 'delete from library', 'delete downloaded chapters', or both.

Other details

No response

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.15.2.4.
[X] I will fill out all of the requested information in this form.

LittleFreak commented 7 months ago

1a) Switch long and short tap behaviors - short tap to change categories, long to remove. However, this may be a learning curve for long-time users. 1b) Make the heart only change the categories, but add a button to delete from library. 2) Add a 'are you sure' prompt 3) Adopt the menu from deleting on the library view - ask whether to 'delete from library', 'delete downloaded chapters', or both.

In my humble opinion, 3) would be the best solution of all. It provides at least some practical reason behind adding a popup. Maybe it's just me, but I'm always annoyed, when a PC/App asks me are you sure? >Are you sure, that you consent to delete your data?> Bob told me, thats a bad Idea, so pls click no ~~Sorry, I got carried away.~~ I don't think adding a separate Button would solve your case because it just moves the issue at hand. It probably won't be long before someone else asks about adding a prompt anyway.

mm12 commented 7 months ago

In my humble opinion...

I think 1b and 3 are equally valid. I change categories of an entry very frequently but hardly EVER remove them, so 1b might be nice. Then again, a button to delete all downloaded would also be nice

LittleFreak commented 7 months ago

In my humble opinion...

I think 1b and 3 are equally valid. I change categories of an entry very frequently but hardly EVER remove them, so 1b might be nice. Then again, a button to delete all downloaded would also be nice

Well... The implementation of prompt 3) could also provide a function to change categories. Like:

[ ] delete from library
[x] delete downloads
[ ] delete/reset added tracker
[x] change categories (with dropdown or follow up popup)

Unfortunately I can't program (yet), so let's hope someone the devs gets some inspiration ^^

boredSage commented 1 month ago

Like OP said, option 1a is not very good since longtime users will find it very awkward ~(just thinking about it disgusts me tbh)~.

Now option 1b imo having the button just for selecting the categories would make the heart icon (a symbol of affection and belonging, as in the library) pointless and it would have to be changed to something else, like a bookmark or whatever, and I wouldn't like that.

⭐ Option 2 is best one. It's simple, straightforward and really helpful. As for it being annoying, like @LittleFreak said, think about it, how often do we remove a manga/anime from our libraries? Me particularly almost never do it, especially since I'd rather have them in a Dropped or Paused or whatever category then deleting it. And something that makes it even better for is Aniyomi's feature to hide a category. I finally don't have to see all 17 categories I created (yes I have this many).

As for option 3, I find it quite redundant. If I want to just deleted the downloaded chapters can simply select 1 chapter, click on Select All and then delete. Now, if I want to delete from my library and the chapters we already have this option and it's when you remove an entry from the library since a prompt appears at the bottom asking if you want to delete the downloaded chapters. And if you don't press "delete" you'll keep the chapters but remove from the library. Of the functions mentioned by @LittleFreak all but one already exists. As for deleting/resetting the tracker, personally I don't see the point, no further comments

mm12 commented 1 month ago

I finally don't have to see all 17 categories I created (yes I have this many).

those are rookie numbers, you should see how slow my app is.

aniyomiorg / aniyomi