aniyomiorg / aniyomi

An app for manga and anime
https://aniyomi.org
Apache License 2.0
5.12k stars 319 forks source link

Crash on rotating screen twice #1493

Closed suhaien closed 3 months ago

suhaien commented 8 months ago

Steps to reproduce

  1. Open aniyomi
  2. Rotate screen twice
  3. Crash.

Expected behavior

The app should not crash.

Actual behavior

The app crashes.

Crash logs

No response

Aniyomi version

r7513

Android version

LineageOS 20 (Android 13)

Device

Samsung S9

Other details

https://github.com/aniyomiorg/aniyomi/assets/129636286/016bfabd-8617-4d1c-b1d0-50bd8f66536d

Acknowledgements

fakebhai commented 8 months ago

relevant to #1484 and #1446

shubham926 commented 8 months ago

I have the same issue. App also crashes when I press back while in video player. Its also connected to rotation issue.

Turning Auto Rotate off fixes the issue

suhaien commented 8 months ago

App still crashes on my device even with auto rotate turned off.

https://github.com/aniyomiorg/aniyomi/assets/129636286/1e8bf091-2956-4757-98c7-9243726256fa

suhaien commented 8 months ago

App started crashing since preview r7509, doesn't crash on preview r7507

abdallahmehiz commented 3 months ago

I am guessing this was because of a bug caused by the main activity creating an mpv instance twice. This was fixed on 71e0d44a0b82a708342a8b22e108dd051e2c1615