Covers do not update on all refresh

ziomek64 commented 2 months ago

Steps to reproduce

Covers don't update on pull down in library
Covers don't update on advanced->update covers
Covers update on pull down in opened entry

Expected behavior

Covers should update in all scenarios mentioned or at least 2 and 3

Actual behavior

Covers update only in pull down in entry

Crash logs

No response

Aniyomi version

0.15.2.4

Android version

Android 14

Device

Xiaomi pad 6

Other details

No response

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.15.2.4.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

fakebhai commented 2 months ago

can you show examples or specific cases?

ziomek64 commented 2 months ago

can you show examples or specific cases?

Like what exactly? Happens everywhere, I was surprised I could update like 10 covers. Some sources don't update covers but mangasee does for new volumes etc.

ziomek64 commented 2 months ago

Here https://github.com/aniyomiorg/aniyomi/assets/84880432/40d5d8b5-27ef-4ba9-a187-291f9fc7d66c

ShadowWalkerM commented 2 months ago

Bro try turn off smart update and refresh

fakebhai commented 2 months ago

Bro try turn off smart update and refresh

smart update isn't relevant at all when you update any entry manually. as it clearly falls under "global update".

fakebhai commented 2 months ago

I think option in advanced settings just re-fetches from same available Metadata. as it says "refresh library covers" so I suppose it's used in cases like covers weren't loaded when you added your entry or restored your backup (using same metadata/image-url).

you'll need to make it re-fetch whole Metadata which in this case is available at "more - settings - library - automatically refresh metadata"

ziomek64 commented 2 months ago

I think option in advanced settings just re-fetches from same available Metadata. as it says "refresh library covers" so I suppose it's used in cases like covers weren't loaded when you added your entry or restored your backup (using same metadata/image-url).

you'll need to make it re-fetch whole Metadata which in this case is available at "more - settings - library - automatically refresh metadata"

It's already turned on for me. Smart is off. Is the code the same for single update and whole library?

fakebhai commented 2 months ago

It's already turned on for me. Smart is off. Is the code the same for single update and whole library?

smart update and global update settings apply when you refresh your library or category, it doesn't apply if you open any anime/manga entry and refresh it

ziomek64 commented 2 months ago

Sure, but I'm asking if the code for updating single entry and all is the same. Because it's really weird covers don't update when refreshing whole library.

fakebhai commented 2 months ago

Sure, but I'm asking if the code for updating single entry and all is the same. Because it's really weird covers don't update when refreshing whole library.

good that it isn't, someone with big library size will ddos those sources. but I believe it'll only refresh metadata of unskipped entries but I could be wrong

ShadowWalkerM commented 1 month ago

Bro try turn off smart update and refresh

smart update isn't relevant at all when you update any entry manually. as it clearly falls under "global update".

Sorry didnt know that but it worked for me lol idk

aniyomiorg / aniyomi