Remove useless mpv files in apk

SkyD666 commented 1 month ago

Steps to reproduce

For example, the files under the is.xyz.filepicker package should all be useless

Expected behavior

These useless files should not be included.

Actual behavior

A lot of useless mpv files are included in the apk

Crash logs

No response

Aniyomi version

0.15.3.0

Android version

None

Device

None

Other details

No response

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.15.3.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

endersgergo commented 1 month ago

The classes in the is.xyz.* packages are not useless, but legitimate dependencies of Aniyomi. The is.xyz.mpv provides the implementation for video playback using libmpv and my educated guess is that the filepicker package is a dependency pulled in by mpv.

abdallahmehiz commented 1 month ago

The classes in the is.xyz.* packages are not useless, but legitimate dependencies of Aniyomi. The is.xyz.mpv provides the implementation for video playback using libmpv and my educated guess is that the filepicker package is a dependency pulled in by mpv.

The file picker in the files is the one mpv-android uses, not mpv itself. It's not required to run the player so i see his point in asking for them to be removed.

Sure removing them will give us back 8kb but i think that's quite insignificant compared to the stability that their existence provides when merging from upstream mpv-android in my opinion.

SkyD666 commented 1 month ago

The developer only needs to remove useless files when packaging the mpv-android, and if done properly, this will not reduce the stability of the app.

Details of how to do this can be found here: https://github.com/jarnedemeulemeester/libmpv-android

SkyD666 commented 1 month ago

Also I'm a developer, I use aniyomi's mpv library, but gradle doesn't support removing files from 3rd party libraries, so I can't remove these useless files in my apk, I hope the developer can remove them when upstream packaged with mpv-android, thank you very much!

aniyomiorg / aniyomi