aniyomiorg / aniyomi

An app for manga and anime
https://aniyomi.org
Apache License 2.0
4.8k stars 309 forks source link

Some keyboard related issues that emerged grom nowhere in last two (or three or may be even more ) preview version #1713

Open P0bo opened 1 month ago

P0bo commented 1 month ago

Steps to reproduce

Connect a Wired or Wireless keyboard to your tablet or phone .

Expected behavior

Every thing should work as intended .

Actual behavior

Searching in a extension or globally

1000084190 1000084200

For searching only solution I have found is by using the search key of soft system keyboard but when using physical keyboard and mouse thats inefficient

Screenshot_2024-07-19-15-40-05-34_423fe07c33ed17f15a4e92e5e3a15972

While Video Playback

Play any video then go navigate the video using enter key when on-screen controls are visible (important) -> Any random button gets focused by keyboard (most of the time back button in the upper left corner or the video length button in the lower left corner) and either takes you out of the playback page or toggles that button .

01

In the above example I was first trying to navigate with my arrow keys , then using the enter button

My Keybind

; seek -85 exact
' seek 85 exact
s cycle sub
a cycle audio
. add sub-pos .5
, add sub-pos -.5
> add sub-delay .1
< add sub-delay -.1
\ seek -2.5000 exact
ENTER seek 5 exact
+ add sub-border-size .2000
_ add sub-border-size -.2000
} add sub-font-size 1
{ add sub-font-size -1
- add sub-shadow-offset -.2000
= add sub-shadow-offset .2000
& add osd-border-size -.02
* add osd-border-size 0.2
U add video-align-y -.02
u add video-align-y .02
i script-binding stats/display-page-3
S cycle sub
A cycle audio
 F cycle-values sub-ass-override no force
j seek 0 absolute ; set pause no
d cycle secondary-sid
g cycle sub-font
l cycle-values sub-font "" "Roboto Flex" "Tilt Neon" "Playpen Sans" "Shantell Sans Light" "Edu SA Beginner" "Caveat"
z ignore
v cycle-values sub-ass-style-overrides "*,Bold=1,Outline=1" ""
n add sub-font-spacing .1
m add sub-font-spacing -.1
w no-osd cycle-values panscan 1 0
e no-osd set sid 0
K add sub-scale +0.02
k add sub-scale -0.02

Crash logs

No Crash Logs

Aniyomi version

r7798

Android version

Android 14

Device

Oneplus Pad

Other details

App version: 0.16.4.3-7798 (standard, 1f3be7b52, 125, 2024-07-16T15:47:48Z) Android version: 14 (SDK 34; build OPD2203_14.0.0.610(EX01)) Android build ID: OPD2203_14.0.0.610(EX01) Device brand: OnePlus Device manufacturer: OnePlus Device name: OP59BCL1 (OPD2203) Device model: OPD2203 WebView: Android System WebView 126.0.6478.134 MPV version: 4d32db2 Libplacebo version: v7.349.0 FFmpeg version: n7.0

Acknowledgements

P0bo commented 1 month ago

Edit: added >gets focused by keyboard

In Video playback section

P0bo commented 1 month ago

Media playback

Using space bar to play pause video while the on screen controls are visible doesnt play or pause video , instead focuses back btn in the top left corner and exits the player