search

anja-sheppard / yoctopuce_altimeter

A ROS package for the yocto altimeter
MIT License
0 stars 0 forks source link

Suggestion: use sensor_msgs/FluidPressure for pressure #1

Open gavanderhoorn opened 6 years ago

gavanderhoorn commented 6 years ago

The sensor_msgs/FluidPressure msg would seem to be more semantically correct than a bare float64.

anja-sheppard commented 6 years ago

Thanks for the suggestion! Added via this commit: https://github.com/amstrudy/yoctopuce_altimeter/commit/e33b3c05bd93514dc6b3246028fe84cec1bc60b4

gavanderhoorn commented 6 years ago

FluidPressure uses Pa as unit for the fluid_pressure field. I'm not certain, but based on the comments in your code, I believe the library you use returns hPa? If so, it would seem it needs to be scaled.

anja-sheppard commented 6 years ago

Thank you! I missed that. I fixed this issue in my latest commit.