search

anjaliahlawat / amazon-login-script

The automated test for amazon login page
0 stars 0 forks source link

run lint in the pre commit hook and commit lint #38

Open h2grover opened 3 years ago

h2grover commented 3 years ago

https://github.com/anjaliahlawat/amazon-login-script/pull/37/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L7-L13

I was wondering why you removed commit lint from pre commit hook? And I missed it too.

AC

hook liniting and commit in pre commit hook

h2grover commented 3 years ago

@anjaliahlawat can you please work on this item first

anjaliahlawat commented 3 years ago

https://github.com/anjaliahlawat/amazon-login-script/pull/37/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L7-L13

I was wondering why you removed commit lint from pre commit hook? And I missed it too.

AC

hook limiting and commit in pre commit hook

I told you about this when I used it. Pre-commit hook was taking last commit everytime and not the current input commit message from the terminal. So I tried commit-msg hook, it worked on the current one. That's why I used it. Is it not okay to use commit-msg here?