Open github-learning-lab[bot] opened 3 years ago
ok
Great! Now we're going to set up Semgrep scanning every PR via GitHub actions by creating a semgrep.yml
.
Though we're going to be using GitHub Actions in this workshop, because Semgrep is nice and portable, easily runnable as a standalone binary or Docker, it's pretty easy to set up Semgrep in pretty much any CI platform under the sun.
See these docs for info about setting up Semgrep in GitLab, Buildkit, CircleCI, or other providers, and see here for more info about Semgrep in CI.
semgrep.yml
to repos you want to onboard, etc.).intro-to-semgrep
repo. If you want to add more repos, you select "All repositories" or hand select a few more. You can always update this later via your GitHub profile Installed Applications settings.intro-to-semgrep
repo row.intro-to-semgrep
repo.
semgrep.yml
GitHub Action) to this repo.ok
Great! I've merged in the Semgrep config you set up into this branch so we can iterate on rules and see the results right in this PR.
After the check suite finishes, you should see a PR comment warning about the use of eval()
in the code this PR is adding in eval_test.ts.
And check your notifications in the r2c community Slack, you should see a message from the webhook flagging this issue as well.
One of the key differentiators about Semgrep is how easy it is to write custom rules.
This fundamentally changes how you can leverage static analysis to scale your AppSec program.
Rather than being a black box, one-size-fits-all, "I sure hope the vendor built all the use cases I could ever need," single purpose tool, Semgrep is a Swiss army knife and your imagination is the limit.
Yes, there are over 1,000 out-of-the-box security checks you get for free.
But you can also use Semgrep for:
internal_auth
library for all auth purposes."something dangerous like crypto or parsing XML
, here's how we do it in our company: link to internal docs
."foo()
should always be called before bar()
, else it's a bug."As Semgrep rules look just like the code you're targeting (with some helpful abstractions), many developers and engineering orgs can write custom rules as well (or better!) than security teams.
Why have separate tools when developers and the security team can solve their respective problems with the same tool! 🤝
Alright, let's get into it.
For these exercises we're going to be using the Semgrep playground: https://semgrep.dev/editor, as it's a convenient way to iterate on rules right from your browser, without installing anything.
If you'd prefer, you can also write Semgrep rules offline in your IDE of choice. After all, they're just YAML!
This is the rule we're going to start on, open it in a separate browser tab: https://semgrep.dev/s/clintgibler:juice-shop-eval-try.
In the top left, you can select a "Language" for the rule you're currently writing. In this case, we're using "TypeScript," because Juice Shop is mostly in TypeScript.
The "code is" section is where you write your Semgrep rule.
The // ruleid:juice-shop-eval
comments you see in the Test Code are a special syntax - they're telling Semgrep, "Hey, I expect Semgrep to find a match here."
If you click on the "Advanced" tab (next to "Simple" under the "Semgrep Rule" header on the left hand side), you'll see the raw YAML for the Semgrep rule you're writing. The "Simple" view is just a simplified interface so you don't have to write raw YAML and mess with indentation, etc.
At a high level, Semgrep rules are just the code you're targeting + a few abstractions.
Sometimes you want to abstract away some details from the code you're matching, to make it more generic.
The ellipsis operator (...
) lets you match zero or more arguments, statements, and more.
Here are a few examples:
// insecure_function(...) would match
insecure_function("MALICIOUS_STRING", arg1, arg2)
// var x = ...; would match each of these
var x = "semgrep";
var x = foo && bar || baz;
var x = foo(something);
You can think of the ellipsis operator like .*
in regular expressions.
Sometimes you want to match something, but you don't know what it is ahead of time.
For example, the name of a function, the value of an argument, and so forth.
Metavariables let you do that by using an identifier that starts with a $
and is only uppercase letters, _
, or digits. $X
or $FOO
for example.
Here are a few examples:
// foo($X)
foo(1); // matches, $X = 1
foo(a); // matches, $X = "a"
// foo($X) doesn't match, foo() called with >1 arg
foo(a, b, c);
// Ellipsis operator and metavariables can be combined!
foo(a, b, c); // foo($X, ...) matches, $X = a
foo(a, b, c); // foo(..., $Y) matches, $Y = c
foo(a); // foo(..., $Y) matches, $Y = a
Note that within one pattern, metavariables are enforced to be the same.
So:
// bar($X, $X)
bar(a, a) // matches
bar(10, 10) // matches
bar(a, b) // does not match, a != b
You can think of metavariables kind of like capture groups in regular expressions.
Sometimes you want to combine Semgrep patterns, like:
a()
or b()
foo()
but not if the first parameter is a string literalbar()
but only if it occurs inside the MyClass
class.You can add additional pattern clauses in the simple editor by clicking the +
button on the right hand side of the pattern.
Currently on a few Semgrep operators are available in the simple editor. See the rule syntax docs for all of the tools in your Semgrep rule writing toolbelt.
We'll cover a number of Semgrep's capabilities in this lab, but there are many we won't!
Navigate to https://semgrep.dev/s/clintgibler:juice-shop-eval-try.
TODO
) to match all calls to my_eval()
, regardless of the passed in arguments.my_eval()
with only 1 argument.my_eval()
when the first argument is not a string literal.Hints
my_eval()
...
.
my_eval()
with 1 argument$ARG
.
my_eval()
where the first argument is not a string literal"..."
will match any string, regardless of its value (docs).
pattern-not
filters out matches.
+
button to add a new pattern and select "and is not", which if you switch to the Advanced view, you can see is represented by pattern-not
under the hood.
my_eval()
rule.
This issue collects various links to useful Semgrep resources and documentation in one place so you can reference it if you ever get stuck.
returntocorp/semgrep-rules
repo, as the Registry includes Semgrep rules from other community repos, like NodeJSScan or Go rules by Damian Gryski.Rule Writing
There's a step by step rule writing tutorial here.
If you go to the Playground, you can also click the "Examples" button to view a number of illustrative built-in examples.
And of course, you can also review the over 1,000 rules in @returntocorp/semgrep-rules.
Docs
Semgrep has pretty extensive docs, which you can view here.
Of note:
this
ANDthat
, orthis
but NOTthat
, etc.Community
Feel free to join the r2c community Slack to ask questions (we're super responsive!) or reach out to us on Twitter (@r2cdev), or send us an email at support@r2c.dev.