search

anjishnu / ask-alexa-pykit

A minimalist SDK for developing skills for the Amazon Echo's ASK - Alexa Skills Kit using Amazon Web Services's Python Lambda Functions. Currently supported profiles are for Linux servers and AWS Lambda. Check the appropriate release branch. The cherrypy release branches have added components for request validation.
MIT License
275 stars 58 forks source link

More verbose nosetests #22

Closed hassanshamim closed 8 years ago

hassanshamim commented 8 years ago

Hey dude, I noticed you started doing some refactoring and I thought you might find these tests useful that I wrote for myself anyway because I'm using your library. Also some PEP8 formatting so my editor would stop scolding me.

I realize they're verbose but I just call that thorough 😉 . Anyway take 'em or leave 'em, I won't be offended. Though I'd take a look at the changes to the handler decorators. You don't need to actually return the function wrapper as you're not actually modifying the function at all. Also default handler takes a func as the arg so you don't have to instantiate it.

Thanks again for the library btw.

anjishnu commented 8 years ago

Thanks for the work - I have been lazy in writing tests, and I have no business nitpicking someone else's!

hassanshamim commented 8 years ago

I've got some free time tomorrow if you'd like I can freshen these up a bit to be compatible with your master branch.

anjishnu commented 8 years ago

I'm out tomorrow, but if you make the change I could take a look on monday.

hassanshamim commented 8 years ago

sounds good

hassanshamim commented 8 years ago

tests are passing again. rebased so it'd be a clean merge.