search

anjlab / android-inapp-billing-v3

A lightweight implementation of Android In-app Billing Version 3
Other
2.2k stars 536 forks source link

Update for Billing Client #544

Closed JkMulti closed 11 months ago

JkMulti commented 1 year ago

The library is updated to use billing client version 6.0.1

MaxT49 commented 1 year ago

Thanks a lot ! It's an awesome library, you made a great work

JkMulti commented 1 year ago

Hi, how can I merge my pull request. It's approved.

On Thu, Oct 26, 2023, 10:57 PM Marcos Ybarra @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/anjlab/android-inapp-billing-v3/pull/544#pullrequestreview-1700209392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXA2K7RRYUCP6NDM7VAF2DYBKQBZAVCNFSM6AAAAAA5TVYM5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBQGIYDSMZZGI . You are receiving this because you authored the thread.Message ID: @.***>

serggl commented 1 year ago

This PR does not follow the official upgrade guide from Google: https://developer.android.com/google/play/billing/migrate-gpblv6

Im not sure what the "approver"'s intent was, but this just cant be merged

rajattechnostacks commented 1 year ago

Any update on this ?

rajattechnostacks commented 1 year ago

So many people using this library and waiting for support

JkMulti commented 1 year ago

What should I do?

On Fri, Oct 27, 2023, 4:49 PM rajattechnostacks @.***> wrote:

So many people using this library and waiting for support

— Reply to this email directly, view it on GitHub https://github.com/anjlab/android-inapp-billing-v3/pull/544#issuecomment-1782779711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXA2K7CO5OW3OF7354T4ODYBONTHAVCNFSM6AAAAAA5TVYM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSG43TSNZRGE . You are receiving this because you modified the open/close state.Message ID: @.***>

rajattechnostacks commented 1 year ago

What should I do? … On Fri, Oct 27, 2023, 4:49 PM rajattechnostacks @.> wrote: So many people using this library and waiting for support — Reply to this email directly, view it on GitHub <#544 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXA2K7CO5OW3OF7354T4ODYBONTHAVCNFSM6AAAAAA5TVYM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSG43TSNZRGE . You are receiving this because you modified the open/close state.Message ID: @.>

are you guys going to release new version ? any plans?

rajattechnostacks commented 1 year ago

What should I do? … On Fri, Oct 27, 2023, 4:49 PM rajattechnostacks @.> wrote: So many people using this library and waiting for support — Reply to this email directly, view it on GitHub <#544 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXA2K7CO5OW3OF7354T4ODYBONTHAVCNFSM6AAAAAA5TVYM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSG43TSNZRGE . You are receiving this because you modified the open/close state.Message ID: @.>

support for v5 or newer ?

rajattechnostacks commented 1 year ago

?????

myinnos commented 1 year ago

@JkMulti any update on the upgrading current one? Have you created any new repo directly?

rajattechnostacks commented 1 year ago

Hi ,

As of now, we can't see any update on the library v3, I have started working on my own implementation now,

There is no hopes now, as long as there are not replying anymore on the repo.

Rajat Patel Android developer who want update on this repo 😕

On Wed, Nov 1, 2023, 6:06 PM Prabhakar Thota @.***> wrote:

@JkMulti https://github.com/JkMulti any update on the upgrading current one? Have you created any new repo directly?

— Reply to this email directly, view it on GitHub https://github.com/anjlab/android-inapp-billing-v3/pull/544#issuecomment-1788882964, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GJZRVXYA6MG4D72EVDUMTYCI64PAVCNFSM6AAAAAA5TVYM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYHA4DEOJWGQ . You are receiving this because you commented.Message ID: @.***>

ynsok commented 1 year ago

@JkMulti anything in here ?

danielcshn commented 1 year ago

RIP 😭

rajattechnostacks commented 1 year ago

may they get heaven.not() 🥺

On Fri, Nov 17, 2023, 6:37 AM danielcshn @.***> wrote:

RIP 😭

— Reply to this email directly, view it on GitHub https://github.com/anjlab/android-inapp-billing-v3/pull/544#issuecomment-1815575395, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GJZRU7TFF7HOYCBLJ6XI3YE22F5AVCNFSM6AAAAAA5TVYM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVGU3TKMZZGU . You are receiving this because you commented.Message ID: @.***>

serggl commented 11 months ago

After a long thinking (which I assume was not supported by a community here) I decided to give this change a go. Sorry for a long wait 🤷🏽‍♂️ v2.1.0 was just published to Maven Central.

@JkMulti thank you for taking an initiative here! I had to make some changes to the build tools to the main branch and also put notes to UPGRADING.md document, so you PR ended up unmergeable. All required changes were made directly to the main branch.