search

anjlab / bootstrap-rails

Twitter Bootstrap CSS (with Sass flavour) and JS toolkits for Rails 3 projects
https://github.com/anjlab/bootstrap-rails
729 stars 96 forks source link

Wrong typo for e("\9") #20

Closed linjunpop closed 12 years ago

linjunpop commented 12 years ago

Is it come from LESS ? I don't know. In one of my rails project, it will throw an error in my colleague's mac. I just change it to \9, like other SCSS file does. And everything looks fine.

linjunpop commented 12 years ago

The original LESS code has the e("\9")

https://github.com/twitter/bootstrap/blob/master/less/buttons.less#L56

linjunpop commented 12 years ago

After a research on that. I find e() is the escaping function in LESS. and \9 is a IE hack. So I'm sure the e("\9") here is wrong. The correct one is \9

tsechingho commented 12 years ago

It hurts with compass gem 0.12.0 and above.

But it is fine with compass gem 0.12.rc.1 or without compass gem.

It should be correct without e() function.

yury commented 12 years ago

Thanks for PR. But bootstrap-rails gem pulls sass from http://github.com/yury/bootstrap. Next time, please send PR against that repo. Applied manually. Released v2.0.2.1