search

anjlab / bootstrap-rails

Twitter Bootstrap CSS (with Sass flavour) and JS toolkits for Rails 3 projects
https://github.com/anjlab/bootstrap-rails
729 stars 96 forks source link

Add missing holder.js #48

Closed caike closed 11 years ago

caike commented 11 years ago

Add missing holder.js library that is used to display thumbnail images

rmoriz commented 10 years ago

Do we really need holder.js? it's just used in the bootstrap docs to create example images. Also it requires special attribution when included…

yury commented 10 years ago

@rmoriz, I think, it's good for prototyping. In production you should specify only js files that you need.

rmoriz commented 10 years ago

@yury why make the default for prototyping, not for production? And because documentation is missing, i bet that 99% of the users will not discover this upfront and violate the holder.js attribution license…

caike commented 10 years ago

Good point about the licensing. Maybe submit a pull request to add that to the README ? I'd imagine most people that use bootstrap use it mostly for prototyping, so I think including holder.js makes sense.

yury commented 10 years ago

I removed holder.js from bootstrap.js for now

Entamut commented 10 years ago

Dummy image generator seems to be a good alternative (i.e. http://fpoimg.com/). No need for additional JavaScript. Only inconvenient is no support for offline image generation (like holder.js was providing). Anyway you can always add holder.js on your own. No need to be included in bootstrap :)