Issue with gradients in IE

anjlab / bootstrap-rails

Twitter Bootstrap CSS (with Sass flavour) and JS toolkits for Rails 3 projects

https://github.com/anjlab/bootstrap-rails

729 stars 96 forks source link

Issue with gradients in IE #5

Closed davidsulc closed 12 years ago

davidsulc commented 12 years ago

Hi,

There seems to be an issue with gradients in IE 9 (and lower versions, most likely).

It seems like the DXImageTransform.Microsoft.gradient function calls in mixins.scss get passed 3-digit color codes that aren't processed properly. For example, #333 renders as #000333. At least, that's what the issue seems to be. I've tried fixing this, but unfortunately I've had no luck...

yury commented 12 years ago

There is no simple solution here SASS doesn't support expanding to IE hex string Compass has it's own implementation

Still thinking about it...

davidsulc commented 12 years ago

I tried something similar: https://github.com/davidsulc/bootstrap-rails/commit/87e5ac99eb3dc76e8c81e3675c5ea17faab5871e

I tried earlier with adding the alpha channel, but it made no difference. I'll give it another try...

(I'll rename the function to ie_hex_str it makes much more sense...)

davidsulc commented 12 years ago

Fixed in pull request (https://github.com/anjlab/bootstrap-rails/pull/7). Turns out my solution wasn't far off...

yury commented 12 years ago

@davidsulc, I released new version with the fix. Thanks a lot!