SimpleRDFXMLFormatter escapes Literals too much

anjulmyaccount / cumulusrdf

Automatically exported from code.google.com/p/cumulusrdf

0 stars 0 forks source link

SimpleRDFXMLFormatter escapes Literals too much #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Serve data with the SimpleRDFXMLFormatter that contains a Literal that 
contains a space 

What is the expected output? What do you see instead?
Expected output is something like >Luiz Felipe<
Instead we get >Luiz+Felipe<

The reason is that the same escape function is used for Literals and Resources.

Original issue reported on code.google.com by sebast...@speiserweb.de on 23 May 2012 at 7:46

GoogleCodeExporter commented 9 years ago

I'll handle this one.

Original comment by andreas.josef.wagner on 26 Nov 2013 at 1:03

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Hi, 
I've attached a patch for this issue. 
Actually the patch reorganizes a bit the RDF/XML serializers (Simple & Stax) by 
providing two supertype layers, one for RDF/XML and one (superclass of the 
first one) for (hopefully) all other serializers. 

The base class for all serializer has been provided so all serializers could 
have a centralized behaviour. However I didn't modify at all other serializers 
(just Simple & Stax RDF/XML)

Best, 
Andrea

Original comment by a.gazzarini@gmail.com on 20 Jan 2014 at 3:09

Attachments:

CUMULUSRDF-3.patch

GoogleCodeExporter commented 9 years ago

Hi, 
I attached a new version of the patch...in previous attachment I forgot to 
include the test folder which contains unit tests for updated classes.

Best, 
Andrea

Original comment by a.gazzarini@gmail.com on 21 Jan 2014 at 8:06

Attachments:

CUMULUSRDF-3.patch

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

Hi Andrea,

thanks so much for your work. We really appreciate your help and patches. 
Unfortunately, I already started to work on this issue.

We are in the process of making cumulusRDF more lightweight. In particular, we 
are currently removing all dependencies to the NxParser. See issue 13. Due to 
those changes, I just removed all of our own rdf-writer code and replaced it 
with a standard sesame-writer.

This should not only resolves issue 3, but also helps to focus more on our 
"own" code ;)

I committed my changes to the current development branch. See r744.

However, in general we always welcome contributors to our project. So, if you 
actively use/code cumulusRDF, we would be happy to add you as a committer and 
plan the future development/roadmap.

Thanks again for your support
Andreas

Original comment by andreas.josef.wagner on 22 Jan 2014 at 1:09

GoogleCodeExporter commented 9 years ago

Hi Andreas,
that's great! Absolutely no problem at all for my patch. I saw issue 13 but I 
was not sure if work had already been started on that side. However again, no 
problem at all: it has been just a way to start having a minimum of confidence 
with your code.

I sent you an email for code contribution but briefly yes, I definitely would 
like to contribute.

Thanks,
Andrea

Original comment by a.gazzarini@gmail.com on 22 Jan 2014 at 6:27

GoogleCodeExporter commented 9 years ago

This is done. However, we could also remove this package completely, as the 
current code merely "wrapps" around Sesame Writers.

Original comment by andreas.josef.wagner on 26 Jan 2014 at 12:21

Changed state: Fixed