search

anjulmyaccount / cumulusrdf

Automatically exported from code.google.com/p/cumulusrdf
0 stars 0 forks source link

Configuration keys should be defined as constants in the Configurator interface #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
See title

Original issue reported on code.google.com by Isib...@gmail.com on 14 May 2014 at 8:55

GoogleCodeExporter commented 9 years ago 
Also, default parameters should be set in the configurator.

Original comment by Isib...@gmail.com on 14 May 2014 at 8:59

GoogleCodeExporter commented 9 years ago 
mmmm...I'm not so convinced about that: keys can be different between 
storages...the configurator is unaware about the specific storage we use.

Original comment by a.gazzarini@gmail.com on 14 May 2014 at 11:54

GoogleCodeExporter commented 9 years ago 
Well, we have cassanrda- prefixes for the Cassandra options. Those prefixes are 
for the configurables. We shouldn't write get("cassandra-x-y"), but 
get(ConfigurationParameters.X_Y), or something similar. Also, we could then 
validate the configuration file and check if there is an invalid parameter.

Original comment by Isib...@gmail.com on 14 May 2014 at 11:56

GoogleCodeExporter commented 9 years ago 
It can of course also be any other place, but we shouldn't have to use strings 
when getting a parameter.

Original comment by Isib...@gmail.com on 14 May 2014 at 12:00

GoogleCodeExporter commented 9 years ago 
I think this should be a responsibility of the concrete class that needs a
set of parameters (in accept method) . Putting all those stuff in
configuration or in default configurator will require a change ech time
something changes and most important, for one instance of cumulus the most
part of those names make no sense (e.g. you're running HBase but as
developer you will find a lot of other parameters that are for other
storages)

In addition,

"Well, we have cassanrda- prefixes for the Cassandra options."

Is not really true, becayse for example the same parameter for 1.2.x e 2.x
takes different values (in C12x cassandra-hosts=<host>:<port> and C2x only
the <host>. That's the reason why in C2x I called that parameter "hosts")

In general, this kind of things, names, should be in dedicated modules. So
I'd vote for inteface in deciated modules with all expected names.

What do you think?

2014-05-14 13:57 GMT+02:00 <cumulusrdf@googlecode.com>:

Original comment by a.gazzarini@gmail.com on 14 May 2014 at 12:03

GoogleCodeExporter commented 9 years ago 
Yes, that'd be good.

Original comment by Isib...@gmail.com on 14 May 2014 at 12:04

GoogleCodeExporter commented 9 years ago 
Ok, so i will open a new issue for that interfaces

Best,
Andrea

2014-05-14 14:04 GMT+02:00 <cumulusrdf@googlecode.com>:

Original comment by a.gazzarini@gmail.com on 14 May 2014 at 12:16

GoogleCodeExporter commented 9 years ago 
Closed because issue #75

Original comment by a.gazzarini@gmail.com on 14 May 2014 at 12:18