Closed ank1traj closed 1 year ago
Can i try this one?
Hi @saimadhav24
That sounds great! Thank you for expressing your interest in adding a footer. We welcome any contributions that can enhance the user experience of our platform. Please feel free to take the issue. We look forward to seeing your contributions.
Thanks 😊
@ank1traj Thank you
@ank1traj Wt links shd be put in footer?
@saimadhav24 For now you can put dummy data. Later we'll change that accordingly.
@ank1traj You fix it, i will try to finish it by that date
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: test-generator@0.1.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR! react@"18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0 || ^17.0.0" from @material-ui/core@4.12.4
npm ERR! node_modules/@material-ui/core
npm ERR! peer @material-ui/core@"^4.0.0" from @material-ui/icons@4.11.3
npm ERR! node_modules/@material-ui/icons
npm ERR! @material-ui/icons@"^4.11.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! C:\Users\SAI MADHAV\AppData\Local\npm-cache\_logs\2023-04-10T03_18_54_118Z-eresolve-report.txt
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\SAI MADHAV\AppData\Local\npm-cache\_logs\2023-04-10T03_18_54_118Z-debug-0.log
I was getting this error while installing packages, itseems there is a conflict between material-ui requirement and reactjs version,
yesterday i used npm i --force
but i think it resulted in incorrect ouputs
edit: i think i resolved it
npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: test-generator@0.1.0 npm ERR! Found: react@18.2.0 npm ERR! node_modules/react npm ERR! react@"18.2.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.8.0 || ^17.0.0" from @material-ui/core@4.12.4 npm ERR! node_modules/@material-ui/core npm ERR! peer @material-ui/core@"^4.0.0" from @material-ui/icons@4.11.3 npm ERR! node_modules/@material-ui/icons npm ERR! @material-ui/icons@"^4.11.3" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! npm ERR! For a full report see: npm ERR! C:\Users\SAI MADHAV\AppData\Local\npm-cache\_logs\2023-04-10T03_18_54_118Z-eresolve-report.txt npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\SAI MADHAV\AppData\Local\npm-cache\_logs\2023-04-10T03_18_54_118Z-debug-0.log
I was getting this error while installing packages, itseems there is a conflict between material-ui requirement and reactjs version, yesterday i used
npm i --force
but i think it resulted in incorrect ouputsedit: i think i resolved it
Always try to pull the latest code @saimadhav24
This is what i am thinking to make footer, any suggestions for this?
@saimadhav24 Can we do subscribe little better?
@ank1traj This is a new design that i am thinking it will be good looking, what is your opinion, i will be trying more of it, but for now this is what i have thought, pls share your opinion
This is another design:
on hovering it becomes like this:
The differnce is: It zooms a bit on hovering and changes the color
This is another design:
On hovering, it turns into something like this:
@saimadhav24 There is no need of first name and last name. Only email ID is enough. Also, if possible then keep the button and input in the same div(same line).
I tried keeping button and input in same line but the result was not that good
I will remove first_name and last_name
this can also be done but while using it in a smaller device it might be giving trouble,
on hovering it becomes:
On the small device you can keep it in two line. Take this example https://startup-gules.vercel.app/
@ank1traj Hello, so i have been working on footer thing, and i had few problems so couldnt update you, here are few screenshots of new design(these represent for different screen sizes):
Note: I know that still i have to modify them, this is just a prototype, hope you like this
Good work @saimadhav24.
@ank1traj I am just discovered this issue, when on homepage in a smaller screen:
the footer is getting faded away by some additional element, any idea how to prevent it?
@saimadhav24 You can fix this
@ank1traj Was able to fix the gradient, but found out a new issue , u can see it in the following pic:
the part "By Ankit Raj" is floating all over the page, will be working on it
@ank1traj I am just discovered this issue, when on homepage in a smaller screen:
the footer is getting faded away by some additional element, any idea how to prevent it?
@saimadhav24 Sorry I just read the first point. Missed the second part. If you need help you can ask whatever issue you are facing.
@ank1traj I think this is fine for now
@saimadhav24 either you can bring the name in centre or remove that.
Update:
@ank1traj Do you want me to raise a pr? or do you need any more changes?
You can raise the PR @saimadhav24
Hey @ank1traj , what should i mention for this:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Hey @ank1traj , what should i mention for this:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- [ ] Test A
- [ ] Test B
Test Configuration:
- Firmware version:
- Hardware:
- Toolchain:
- SDK:
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Hi @saimadhav24,
You can add your system configuration.
Thank you @ank1traj , I will be raising pr by tonight or by tmrw evening
@ank1traj Hi, I need some time to create PR, I am currently busy with my college reviews, I will create PR as soon as I finish my review
@ank1traj , Hi , I have raised PR with whatever details i know, you can check it once and let me know if anything has to be changed, thank you
Currently, our website is missing a footer section. This makes the website design look incomplete and unprofessional. To improve the user experience and make our website look more polished, we should add a footer section.
The footer section will be located at the bottom of every page and will include important information such as the company name, copyright information, contact information, and links to important pages such as the About Us page and Terms of Service.
The footer should be designed to match the overall theme and color scheme of the website. It should be visually appealing and easy to navigate. The links in the footer should be clickable and lead to the appropriate pages.
Adding a footer section will not only improve the website design but also provide important information to our users and improve their overall experience on our website. Therefore, we should prioritize this issue and add a footer section as soon as possible.