Navigation bar Issue #14

[yuvrxj-afk]

Description

Added a Navbar which include links to different pages on the website, such as the home page, about us page, contact us page and other relevant pages.

Fixes # (Add Navigation Bar) #14

Type of change

Removed the Contribute section and added to navbar , media queries to be defined in the next commit after a review.

Please delete options that are not relevant.

• [✔] Bug fix (non-breaking change which fixes an issue)

• [✔] New feature (non-breaking change which adds functionality)

• [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

• [] This change requires a documentation update

Checklist:

• [✔] My code follows the style guidelines of this project
• [✔] I have performed a self-review of my own code
• [✔ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [✔ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @ank1traj on Vercel.

@ank1traj first needs to authorize it.

[ghost]

👇 Click on the image for a new way to code review

#### [](https://app.codesee.io/r/reviews?pr=26&src=https%3A%2F%2Fgithub.com%2Fank1traj%2Ftestcase-generator) #### Legend

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
testcase-generator	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 11, 2023 4:50pm

[ank1traj]

Hi @yuvrxj-afk

please remove the package-lock.json file

[ank1traj]

📝 Changed routes:

/about	/contact
(view full size)	(view full size)

/
(view full size)

Commit f78896e5281542caa1a6ae103a3298a1420b65db (https://testcase-generator-4wjyolpzo-ank1traj.vercel.app).

[ank1traj]

@yuvrxj-afk Aren't we going to add navigation bar in every routes and also I think navigation bar is not responsive. Correct me if I am wrong.

[yuvrxj-afk]

We need to remove components from index.js and I mean that create nav/description/cards separately , not in a single file, then It won't be so complex.

[ank1traj]

@yuvrxj-afk This should be done completely. If you don't have bandwidth/time you can convey that. What is required is complete closure of the issue. Not by part by part.

[yuvrxj-afk]

I'm having some work , will try to commit soon @ank1traj In between if anyone can contribute that would be so great.

[yuvrxj-afk]

will be adding rest pages in issues , where others can contribute to navbar linked pages.

[ank1traj]

@yuvrxj-afk Could you please resolve the conflicts?

[yuvrxj-afk]

@ank1traj would you please review?

[ank1traj]

@ank1traj would you please review?

Dropped some comments. Have a look.

[yuvrxj-afk]

Dropped some comments. Have a look.

Didn't get it. Sentry ones?

[ank1traj]

Dropped some comments. Have a look. Didn't get it. Sentry ones?

First deployment is getting failed due to searchbar not found

Second if you see the review one. You will get my comment. Even if you scroll this PR you will get that.

[ank1traj]

@yuvrxj-afk Please look into this blog - https://dev.to/rhammy/path-aliases-in-nextjs-2fnc

[ank1traj]

@yuvrxj-afk what was the need of search bar? What it's providing here?

[yuvrxj-afk]

You mentioned the search bar in the navbar issue's description, so created the component, which can be used later with functionality.

[ank1traj]

You mentioned the search bar in the navbar issue's description, so created the component, which can be used later with functionality.

@yuvrxj-afk In dark mode search bar is not visible at all. What we can do is leave the search bar for now. As, we don't have any functionality of search.

[yuvrxj-afk]

Surely, i should make one more commit , we'll add it later with functionalities as we have to fetch as well.