search

anka-213 / webcomic_reader

Webcomic Reader userscript at
https://openuserjs.org/scripts/anka-213/Webcomic_Reader
MIT License
120 stars 27 forks source link

Remove debugger in run_script() #42

Closed stevenbriscoeca closed 7 years ago

stevenbriscoeca commented 7 years ago

Hello,

Thank you for continuing this great script. I noticed that there was a debugger in one of the global functions. I think it would be smart to remove it because I personally don't think this should be in a prodution file.

First PR, hopefully the first of many!

Thanks!

anka-213 commented 7 years ago

I'm a bit conflicted on this one. On one hand, I agree, on the other hand, I find it very convenient. Since there is no way to put breakpoints in a userscript from Crome Developer tools, without stopping there first, I'd have to add it every time I want to debug the script.

"... hopefully first of many!" Yay! I'd love having a co-developer on this project. :D

stevenbriscoeca commented 7 years ago

Hmm I understand the problem, maybe we could do a dev version and distribution version.

What do you think? People would just install the distribution without the debugger.

stevenbriscoeca commented 7 years ago

If not we can close this.

anka-213 commented 7 years ago

After thinking a bit more, I'll merge this. Thanks.