search

anka-213 / webcomic_reader

Webcomic Reader userscript at
https://openuserjs.org/scripts/anka-213/Webcomic_Reader
MIT License
120 stars 27 forks source link

Horizontal Scrollbar issue #49

Open iZN1337 opened 7 years ago

iZN1337 commented 7 years ago

I'm not sure what's wrong, but I've only enabled Auto Zoom with "Shrink to fit width" to Always Shrink so that it may fit my whole browser's window. The issue is exactly the same for me as someone created this issue 1 year ago at the original repo..

Is there any possibility of solving it? I'm using this script for bato.to. BTW, great script and thanks for continuing the development. I recently found it.

DCTest1 commented 7 years ago

I just checked myself, and it works in Minimalistic View when you configure the script right. On AutoZoom in the settings you have to disallow shrinking AND expanding on height while explicitly forcing shrinking AND expanding on width. Do this for the bato.to settings alone (2nd column) so every site except bato.to works as intended. It has to use Minimalistic View because every site uses a different layout and to properly scale the image to the width of the screen it would need to ignore the borders and frames that are on the side of each image. Seriously you could have just looked at the settings in AutoZoom and figured that out on your own.

iZN1337 commented 7 years ago

Ah, shit. Sorry I've been fiddling around with the AutoZoom setting but I actually didn't even notice the Minimalistic View, and indeed it works perfectly as it should. I've disabled the width expanding though because it expands the lesser width images (i.e. single page are mostly shorter in width, but the double spreads are higher in width). Thanks again mate!

anka-213 commented 7 years ago

@iZN1337 It should work even without minimalistic mode as well though. Can you include a screenshot of the problem and a link to a page with the issue? Or, if you don't care about normal mode, I'll just ignore the issue. ;)

iZN1337 commented 7 years ago

@anka-213:

Well, it doesn't really bothers me, but I'll tell the details anyway.

The site I'm using is bato.to. I'm reading JoJo Part 5: Vento Aureo. They have double spreads for the colored edition especially. The resolution of each page is "1560x1200" Here's an example page with the said scanlation team (the link will expire soon). Here's a direct link to one of the image.

(If the link expires): Select the first chapter that is "Vol. 47 Ch. 440: Gold Experience Part 1. (Official Color Scans)" of scanlation team called "Jojo's Colored Adventure - English" from the first main batoto link I mentioned.

My laptop's resolution is 1366x768, using Windows 10 x64 Pro (latest updates) and I'm also using the latest version of Chrome.

Images:

  1. With minimalistic mode
  2. Without minimalistic mode (pressing Z to zoom gives the same result -- which is a feature of bato.to to fully open the said image)

As you can see it cuts abit of the image from the left side. It also cuts larger part if the image is larger. (happened with me while I was reading Hajime no Ippo as well, one of the double spread looked the same as above images but with more cropping at the left side).

If you're feeling like solving it, it'd be great of you. Even if you leave things as it is, I believe it should be fine either way.

anka-213 commented 7 years ago

Awesome, thanks! I'll look at it when I have time. Do you know when the links will expire?

iZN1337 commented 7 years ago

No clue, it depends on if bato.to wants it gone. Should stay for a week or two.

EDIT (10/11/16): It's still up.

EDIT (04/04/17): Updated the link. It's up again.