anka-213 / webcomic_reader

Webcomic Reader userscript at
https://openuserjs.org/scripts/anka-213/Webcomic_Reader
MIT License
120 stars 27 forks source link

Does not work with videos #64

Open FichteFoll opened 7 years ago

FichteFoll commented 7 years ago

Using the script on sites where you may encounter both images and videos, such as danbooru, makes the script stop loading previews when it encounters the first video. An example can be seen on this page: https://danbooru.donmai.us/posts?tags=animated&page=

console:

loadFail(2,1,1,0) - load: {"img":"https://danbooru.donmai.us/data/__rumia_touhou_drawn_by_natsu_no_koucha__b52a789271c0d82c0f67d7fecccb5584.mp4"}  webcomic_reader.user.js:6006:29
loadFail(2,1,1,1) - load: null  webcomic_reader.user.js:6006:29
loadFail(2,1,1,0) - load: {"img":"https://danbooru.donmai.us/data/__kasumigaoka_utaha_saenai_heroine_no_sodatekata_drawn_by_musyasabu__94b8cd6cee41fcfecb7e76c07bf1f212.mp4"}  webcomic_reader.user.js:6006:29
loadFail(2,1,1,1) - load: null  webcomic_reader.user.js:6006:29

Technically, previews are still being loaded, but when the next "image" is a video, you can't navigate to it and any subsequent images/videos.

anka-213 commented 7 years ago

Yes, this has been a problem before on other sites. It's kind of hard to fix though, since the script is fundamentally built around there being exactly one image on each page and when it doesn't find one it's a failure. But I can see if I can find a workaround, or at least ignore the videos if I can't display them.

2017-02-03 12:37 GMT+01:00 FichteFoll notifications@github.com:

Using the script on sites where you may encounter both images and videos, such as danbooru, makes the script stop loading previews when it encounters the first video. An example can be seen on this page: https://danbooru.donmai.us/posts?tags=animated&page=

console:

loadFail(2,1,1,0) - load: {"img":"https://danbooru.donmai.us/data/__rumia_touhou_drawn_by_natsu_no_koucha__b52a789271c0d82c0f67d7fecccb5584.mp4"} webcomic_reader.user.js:6006:29 loadFail(2,1,1,1) - load: null webcomic_reader.user.js:6006:29 loadFail(2,1,1,0) - load: {"img":"https://danbooru.donmai.us/data/__kasumigaoka_utaha_saenai_heroine_no_sodatekata_drawn_by_musyasabu__94b8cd6cee41fcfecb7e76c07bf1f212.mp4"} webcomic_reader.user.js:6006:29 loadFail(2,1,1,1) - load: null webcomic_reader.user.js:6006:29

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/anka-213/webcomic_reader/issues/64, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdBO0ouvoR4o6DC6pUakwQ5DYq90fXOks5rYxFhgaJpZM4L2Ox1 .