Update README to provide more accurate geocoding info

ankane / ahoy

Simple, powerful, first-party analytics for Rails

MIT License

4.24k stars 377 forks source link

Update README to provide more accurate geocoding info #486

Closed JustinAiken closed 3 years ago

JustinAiken commented 3 years ago

Geocoding is on by default: https://github.com/ankane/ahoy/blob/2515f80d50657014c1531dac05e1f5b4045cb47e/lib/ahoy.rb#L46-L47

But the current README makes it seem like it's not. We noticed this when we had 10's of thousands of geocode jobs in our sidekiq queue 😂

ankane commented 3 years ago

Hey @JustinAiken, thanks for the PR! The readme was targeted at new installations, which disabled it by default in the generated intializer (but agree it's confusing):

https://github.com/ankane/ahoy/blob/afbac31077693b68cc00903b58ee8ba1d9bad122/lib/generators/ahoy/templates/database_store_initializer.rb.tt#L7-L10

Starting with Ahoy 4.0 (just released), it's now disabled by default for all installations.