search

ankane / ahoy_email

First-party email analytics for Rails
MIT License
1.11k stars 137 forks source link

Post Process Inline with Roadie #121

Closed Hamdan85 closed 5 years ago

Hamdan85 commented 5 years ago

This change ensures emails are following inline css guidelines in order to prevent layout style broke in clients like gmail.

For some reason, after the Nokogiri HTML reasembly, sometimes HTML loses some styles. This loss pass unobserved in many cases, but, specifically in gmail, it becomes huge.

For this reason I added Roadie gem and used the transform method to reprocess the html and ensure it's correct.

ankane commented 5 years ago

Hey @Hamdan85, thanks for the PR, but we need to understand exactly what it's fixing first. Also, adding a dependency on Roadie isn't ideal. It'd be better to understand how Roadie uses Nokogiri and follow that.

Hamdan85 commented 5 years ago

@ankane I do think you are probably right, but the problem is that for now, something is braking the css. I would advise to merge ir until a better solution comes up, but Im just proposing here lol...

But also, maybe we should call for @sparklemotion to try something out, because I actually still dont know if this a Nokogiri issue or AhoyEmail's.

ankane commented 5 years ago

@Hamdan85 It's not a Nokogiri issue since Roadie uses Nokogiri and doesn't have the same issue. And as I mentioned before, it doesn't make sense to merge something that neither you or I understand. You're welcome to use your fork, but if you want to contribute to the community, you'll need to spend the time to understand what's going on. I don't want to continue to go back and forth on this like we did with the Groupdate report.

ankane commented 5 years ago

Cleaning up stale PRs

Hamdan85 commented 5 years ago

Ok Andrew... I'll manage it to do my research with more time. Things are pretty messy here but I'm willing to contribute.

Thanks for you support.

Em qui, 17 de jan de 2019 21:29, Andrew Kane notifications@github.com escreveu:

Closed #121 https://github.com/ankane/ahoy_email/pull/121.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ankane/ahoy_email/pull/121#event-2081656887, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzHStpr145zyC1PiDrgvikdLHz3BpHxks5vEQdAgaJpZM4YYVCa .