ankane / ahoy_email

First-party email analytics for Rails
MIT License
1.11k stars 137 forks source link

Use RuboCop? #143

Closed utkarsh2102 closed 4 years ago

utkarsh2102 commented 4 years ago

Hi @ankane,

Thanks for maintaining this (and all the other wonderful gems) so far! However, there are a bunch of things that could be fixed according to the Ruby style guide.

Would you consider using RuboCop? I would be happy to raise a PR if so :)

ankane commented 4 years ago

Hey @utkarsh2102, thanks for the suggestion. I'm personally not a fan of linting (may put my detailed thoughts into a blog post at some point).

utkarsh2102 commented 4 years ago

Hiya,

I'm personally not a fan of linting (may put my detailed thoughts into a blog post at some point).

Oh sure :smile: I'd love to read that! \o/

Anyway, thanks for your work! :rocket: