search

ankane / blazer

Business intelligence made simple
MIT License
4.56k stars 474 forks source link

Compatibility with Propshaft #379

Closed jankeesvw closed 2 years ago

jankeesvw commented 2 years ago

In Rails 7, the default is to compile assets is via jsbuilding-rails and cssbuilding-rails unfortunately Blazer relies on Sprockets because of the //= require in the sass files.

It would be great if Blazer worked with Propshaft.

jankeesvw commented 2 years ago

As a temporary workaround I added the compiled versions of the assets to our project, this is served by Propshaft:

image

ankane commented 2 years ago

Hey @jankeesvw, Sprockets is still the Rails default (rails new hello && grep sprockets hello/Gemfile) and what I think is the best choice for engines at the moment. It sounds like Propshaft may replace Sprockets at some point, so will revisit then. https://github.com/rails/propshaft#will-propshaft-replace-sprockets-as-the-rails-default

jankeesvw commented 2 years ago

While I 100% agree with your stance, I think more people are going to require this.

If someone willing to join I would love to create a PR for this.

In the meantime I'll close this issue 👍

ankane commented 2 years ago

Added experimental support in the commit above if you want to give it a shot.