ankane / blazer

Business intelligence made simple
MIT License
4.5k stars 471 forks source link

Frozen array error with Trilogy and Rails 7.2 #481

Closed jenshenny closed 1 week ago

jenshenny commented 1 week ago

When using the Trilogy adapter and Rails 7.2, I'm getting a frozen array error for every query.

Screenshot 2024-09-04 at 11 54 28 AM

After looking into it, columns is now frozen in Rails 7.2. https://github.com/rails/rails/commit/9652207c6b12ccdfd7067b874f8ceff10c54d2b4

To fix it we can dup the columns array on https://github.com/ankane/blazer/blob/master/lib/blazer/adapters/sql_adapter.rb#L47

columns = columns.map { |k| k.dup.force_encoding(Encoding::UTF_8) }