ankane / prophet-ruby

Time series forecasting for Ruby
MIT License
396 stars 11 forks source link

Do we need the logging about disabling seasonality? #16

Closed epugh closed 1 year ago

epugh commented 1 year ago

First off, I want to say how great these ML related gems have been. I've been using this gem to help me figure out how to look for the last interesting "bend" in a set of scores, and provide a useful message. The changepoint stuff is (I think) what I needed.

Screenshot at Aug 03 19-19-00

One thing I notice is that in my logs I see:

[prophet] Disabling yearly seasonality. Run prophet with yearly_seasonality: true to override this.
23:15:49 web.1    | [prophet] Disabling daily seasonality. Run prophet with daily_seasonality: true to override this.
23:15:49 web.1    | [prophet] n_changepoints greater than number of observations. Using 23

The first two seem like it would be nice to disable them.

The third one is potentially interesting... I have 31 data points in the example above.

epugh commented 1 year ago

BTW, my usage is in https://github.com/o19s/quepid/pull/684/commits/517ed770d227b3aeeb5e3dc95b5531099ff9dede though as part of my poc, it's mostly in the _case_summary.html.erb view ;-).

ankane commented 1 year ago

Hi @epugh, logging will be disabled by default in 0.5.0 (883164f44fad5a89696b8c509f2fe734829074c1).

epugh commented 1 year ago

Awesome! Looking froward to it!

epugh commented 1 year ago

About to update to the new release, thank you for this!