Fixed unmount destroy chart

ankane / react-chartkick

Create beautiful JavaScript charts with one line of React

https://chartkick.com/react

MIT License

1.2k stars 58 forks source link

Fixed unmount destroy chart #52

Closed xinyifly closed 3 years ago

xinyifly commented 3 years ago

Currenty, componentWillUnmount is not calling chart.destroy() , which leads to a chart component with a refresh option will continuously fetch chart data in background after the chart component is unmounted. This pull request fixes that.

ankane commented 3 years ago

Looks great, thanks @xinyifly! Will push a new release shortly.