search

ankane / react-chartkick

Create beautiful JavaScript charts with one line of React
https://chartkick.com/react
MIT License
1.2k stars 58 forks source link

extraneous-dependencies error (eslint) #53

Closed DanielRuf closed 2 years ago

DanielRuf commented 3 years ago

The eslint rule import/no-extraneous-dependencies throws an error because chartkick is not listed in package.json when you follow the setup steps.

ankane commented 2 years ago

Hey @DanielRuf, thanks for sharing. You can run npm install chartkick to fix, but prefer to keep the installation instructions simple.

DanielRuf commented 2 years ago

Well, the warning is there for good reasons.

import 'chartkick/chart.js'

This will also fail with yarn v2 and probably future npm versions unless we run npm i chartkick. The current approach is not the ideal way.