Refactor to use ES6 classes (fixes #3)

ankane / react-chartkick

Create beautiful JavaScript charts with one line of React

https://chartkick.com/react

MIT License

1.2k stars 58 forks source link

Refactor to use ES6 classes (fixes #3) #9

Closed caycecollins closed 6 years ago

caycecollins commented 6 years ago

fixes #3

ankane commented 6 years ago

Hey @inergy, thanks for the PR 👍 Is it possible to break this into smaller changes?

caycecollins commented 6 years ago

Aside from a few style changes (which I can fix), I think the majority of the change was due to updating webpack. Are your concerns with the component changes (https://github.com/ankane/react-chartkick/pull/9/commits/701354955566da28a9cde919ceee962c1a59c23d) ?

ankane commented 6 years ago

Hey @inergy, thanks for updating. I think the changeset is still bigger than it needs to be. For instance, there are changes in quote style, trailing commands, and things like chartId++ were moved.

ankane commented 6 years ago

I went ahead an incorporated some of these changes in https://github.com/ankane/react-chartkick/commit/a19889bf8738c1be67e58e4f00d9fc25135ef8cb. Will push out a new release shortly. Thanks for driving this forward @inergy 👍