ankeetmaini / react-infinite-scroll-component

An awesome Infinite Scroll component in react.
https://react-infinite-scroll-component.netlify.com/
MIT License
2.85k stars 322 forks source link

Not calling next function on long screens #380

Open ardeshiir opened 1 year ago

ardeshiir commented 1 year ago

When the window is zoomed out and the component is initialized the component will stuck on loading wont call the next function

sample

tofiqquadri commented 1 year ago

@finishedcoot I still have this issue. What's the fix?

techwithanirudh commented 1 year ago

@finishedcoot I'm having the same issue? What's the fix?

techwithanirudh commented 1 year ago

@finishedcoot How could I use your fork without having yarn installed?

ardeshiir commented 1 year ago

@techwithanirudh @tofiqquadri Temporarily you can install the package by changing your package.json to be like this and reinstall the module. But I recommend to change it back after the maintainer fixed this issue ASAP.

"react-infinite-scroll-component": "git+https://github.com/Stacrypt/react-infinite-scroll-component",
LibardoVega commented 1 year ago

hola yo pude resolver el hecho que no llame a la función "next", lo que me daba error era usar el componente dentro de una etiqueta que usara "Overflow: auto"

LibardoVega commented 1 year ago

acabe de revisar bien la documentación y hace falta el "scrollableTarget" con eso ya pude usar el "Overflow: auto"

tofiqquadri commented 1 year ago

I avoided using this library since it has this major bug open and it has not yet solved.

Instead of this I used IntersectionObserver and implemented the functionality of this library myself.

kimkong88 commented 1 year ago

I am too waiting on this!

Fernando-Hooklab commented 1 year ago

I'm having the same issue!

kimkong88 commented 1 year ago

I'm having the same issue!

my workaround was just to fetch enough data for single page OR have each item card large enough to fit scroll.. OR load more manually(not waiting for scroll to reach the bottom) based on height

ryanschiang commented 1 year ago

Issue still persists. See this codepen for example: https://codesandbox.io/s/amazing-hermann-x2qw8m?file=/src/index.js

Unfortunately this cripples the library for anything besides simple/single-page infinite scroll apps.

ryanschiang commented 1 year ago

Here's my workaround InfiniteScroll component, using IntersectionObserver:

interface InfiniteScrollProps {
  load: () => void;
  hasMore: boolean;
  loader: React.ReactNode;
  children?: React.ReactNode;
  endMessage?: React.ReactNode;
}

export const InfiniteScroll: React.FC<InfiniteScrollProps> = ({
  load,
  hasMore,
  loader,
  children,
  endMessage,
}) => {
  const sentinelRef = useRef<HTMLDivElement>(null);
  const observerRef = useRef<IntersectionObserver | null>(null);

  const handleIntersect = useCallback(
    (
      entries: IntersectionObserverEntry[],
      observer: IntersectionObserver
    ) => {
      // Check if the sentinel element is intersecting, and if so, call the load function
      if (entries[0].isIntersecting && hasMore) {
        load();
      }
    },
    [load]
  );

  useEffect(() => {
    // Create a new IntersectionObserver when the component mounts
    observerRef.current = new IntersectionObserver(handleIntersect, {
      root: null,
      rootMargin: "0px",
      threshold: 1.0,
    });

    // Attach the observer to the sentinel element
    if (sentinelRef.current) {
      observerRef.current.observe(sentinelRef.current);
    }

    // Clean up the observer when the component unmounts
    return () => {
      if (observerRef.current) {
        observerRef.current.disconnect();
      }
    };
  }, [load]);

  useEffect(() => {
    // When the hasMore prop changes, disconnect the previous observer and reattach it to the new sentinel element
    if (observerRef.current && sentinelRef.current) {
      observerRef.current.disconnect();
      observerRef.current.observe(sentinelRef.current);
    }
  }, [hasMore]);

  return (
    <div>
      {children}
      <div ref={sentinelRef}>{hasMore && loader}</div>
      {!hasMore && endMessage}
    </div>
  );
};
eamador commented 11 months ago

You can workaround this issue with a hook, check the following response

https://github.com/ankeetmaini/react-infinite-scroll-component/issues/391#issuecomment-1734154621

fridaystreet commented 1 month ago

IntersectionObserver

any chance you could expand on that a bit?