Add functionality to integrate exposure, baseline, design into a single treatment ratio file

ankemt / MEAanalysis

GNU General Public License v3.0

0 stars 0 forks source link

Add functionality to integrate exposure, baseline, design into a single treatment ratio file #21

Closed bvreede closed 1 year ago

bvreede commented 1 year ago

Some TODOs:

[x] Is the absolute vs ratio correct? absolute is now calculated as a ratio, and ratio is simply absolute * 100...
[x] Metadata is collected but not processed
[x] Should we do anything with the electrode data?
[x] What should come out of this function? Right now, the treatment ratio df is produced. Should it be saved somewhere?
[x] Add some more tests!

Closes #19

bvreede commented 1 year ago

Also, this creates more global unbound variables. We really need to figure those out! See #15

treatment_ratio: no visible binding for global variable
    ‘Exposure_value’
  treatment_ratio: no visible binding for global variable
    ‘Baseline_value’
  treatment_ratio: no visible binding for global variable
    ‘Treatment_absolute’

bvreede commented 1 year ago

While there are still a number of #TODOs in the code, I think it may actually be time to merge this. The reason is that I expect we will have to tweak a number of things still, and we will know more as we use this function in the rest of the package.

If you agree @ankemt, we can put the code review on the agenda for Friday 11/11 🙃 🎉