search

ankenyr / jellyfin-smartplaylist-plugin

GNU Affero General Public License v3.0
52 stars 12 forks source link

Add regex operators and some operands #8

Closed arition closed 3 years ago

arition commented 3 years ago
  1. add new operators: MatchRegex and NotMatchRegex.
  2. add new operands: MediaType, Album, DateCreated, DateLastRefreshed, DateLastSaved, DateModified.
  3. cleanup Factory.cs and Expression.cs: replace all tabs to spaces (consistent to other files).
arition commented 3 years ago

@ankenyr In case you miss the pr

ankenyr commented 3 years ago

Hey sorry I did not see this. Have a new born at home.

This looks fine, mind adding some to the documentation to cover this?

also FYI I have been considering rewriting the engine to use straight sql instead of linq as the process of asking for the entire library and then iterating over it seems to take a long time for my library. Let me know if you wanted to collaborate more. I am on the jellyfin matrix server if you wished to chat there.

arition commented 3 years ago

Updated documentation for operators.

For collaboration, sorry I am pretty new on jellyfin code structure and I am afraid I can't help much on rewriting. Thank you for your invitation anyways!

ankenyr commented 3 years ago

No worries, I am still a novice to C# myself. Plugins however do not need knowledge of jellyfins internal structure for the most part.