search

ankenyr / jellyfin-youtube-metadata-plugin

Youtube Metadata Plugin for Jellyfin
GNU Affero General Public License v3.0
481 stars 31 forks source link

Youtube-dl not found on path - Youtubedl-material #64

Closed LukeG20 closed 1 year ago

LukeG20 commented 1 year ago

Hi,

I'm getting a "youtube-dl not found on path!" error when trying to use the plugin. I'm guessing that's because I'm using "Youtubedl-material" rather than directly using "yt-dlp" is there anyway I can get the plugin to pickup the instance of "yt-dlp" that "Youtubedl-material" is using?

ankenyr commented 1 year ago

How did you install material? The instructions mention doing a pip install so if you used yt-dlp it should be in the common location and in your path.

LukeG20 commented 1 year ago

Material is installed on docker using their recommended docker-compose.yml and I installed your plugin via the repository. Material comes with different downloaders the default being yt-dlp guessing that would cause the path break. Would following your instructions under "Installing in a container" fix it? I can live with having two instances of yt-dlp installed.

Thanks for your time, I understand this is caused by me not installing yt-dlp as instructed so its much appreciated.

ankenyr commented 1 year ago

I don't quite understand. Is Material and jellyfin both in the same docker container? If they are in separate containers (which they probably should be) then each container is separate. You will not have access to the binaries in the other container.

ddubnyk commented 1 year ago

I also have this issue actually. Using yt-dlp installed latest version from pip.

Jellyfin 10.8.3 in docker container.

ankenyr commented 1 year ago

Is it installed in the docker container though? Can you show me evidence.of that?

On Tue, Aug 9, 2022, 5:57 AM ddubnyk @.***> wrote:

I also have this issue actually. Using yt-dlp installed latest version from pip.

Jellyfin 10.8.3 in docker container.

— Reply to this email directly, view it on GitHub https://github.com/ankenyr/jellyfin-youtube-metadata-plugin/issues/64#issuecomment-1209348862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALYWLXO3FTX45BDIVHIDPLVYJIU7ANCNFSM55LVLN3Q . You are receiving this because you commented.Message ID: @.***>

LukeG20 commented 1 year ago

I've been able to fix it. It was entirely my fault, as you said with yt-dlp being in another container it wasn't finding it. I used putty to SSH into my Synology NAS and followed your "Installing in a container" instructions and it seems to be working now.

The only issue I'm having is that it's overwriting the episode numbers and listing everything as episode 1 but I'll look into that later. Unless you already know what I'm doing wrong?

ankenyr commented 1 year ago

That is how it works right now. There is a bug possibly that is causing videos new videos to be marked as watched after upgrading to the latest jellyfin. https://github.com/ankenyr/jellyfin-youtube-metadata-plugin/issues/61

That being said, the way it works is the plugin sets all episodes to 1 (testing out 0 to fix the bug) and then a scheduled task comes in and looks at all videos within a season and sorts them by premiere date. This was neccesary as YT videos do not have episode numbers associated with them. A video could appear out of thin air from being marked private and then public again. Its upload date would not be affected. Sorting by that date makes sure there is an order and I update their index after sorting.