search

ankenyr / jellyfin-youtube-metadata-plugin

Youtube Metadata Plugin for Jellyfin
GNU Affero General Public License v3.0
481 stars 31 forks source link

Fix local metadata exiting if file already exists #66

Closed Bryan792 closed 2 months ago

Bryan792 commented 1 year ago

Is this logic correct? Sorry, I am not too involved with the project, so unsure.

Here's the git blame: https://github.com/ankenyr/jellyfin-youtube-metadata-plugin/commit/93f4b2784bca74133f7b9ad08c358ba4f608cff0

Fribb commented 1 year ago

While trying to fix the issue myself I found a few more things that should be done.

  1. The ReadYTDLInfo Is redundant in the AbstractYoutubeRemoteProvider.cs to the Method in the Utils class
  2. ReadYTDLInfo should use the method in the Utils class as well
  3. Same with the Call in the YTDLSeriesProvider here
  4. The File.Exists you changed should then be moved to the Utils.ReadYTDLInfo for a more centralized usage.

This would then cover everything when the ReadYTDLInfo is used, not only for Movies, Series but also for Image requests (where it also fails)

jacksgt commented 3 months ago

Would be great if we can merge this and get a new release out.

nalsai commented 2 months ago

Hey @ankenyr, this fixes a bug introduced in 93f4b2784bca74133f7b9ad08c358ba4f608cff0 that prevents getting metadata from info.json files. Could you merge it please?

Thank you.