search

anki / cozmo-python-sdk

Anki Cozmo Python SDK
Other
662 stars 430 forks source link

Update opengl.py #172

Closed AndreiCostinescu closed 6 years ago

AndreiCostinescu commented 6 years ago

Removed unnecessary quotes in the installation instruction of cozmo[3dviewer].

brakhane commented 6 years ago

The quotes are necessary in some shells, like zsh.

AndreiCostinescu commented 6 years ago

Oh, I didn't realize... In my case it didn't work with the quotes and that's why I removed them. Is the documentation string ok now as it is?

MarkWez commented 6 years ago

@AndreiCostinescu What OS / shell were you using that the quotes caused an issue? Note that we also use quotes around other places that pip install with square braces - e.g. cozmo[camera]: http://cozmosdk.anki.com/docs/install-macos.html#sdk-installation (The quotes were added when zsh users reported issues otherwise, but bash etc. are fine with and without them)

AndreiCostinescu commented 6 years ago

Hi @MarkWesleyAtAnki I am using Windows 10 with the standard command prompt (cmd from the Win + r) and I get the error whenever I use quotes around the package I want installed. The square brackets are fine, but not the quotes..

AndreiCostinescu commented 6 years ago

Hi @MarkWesleyAtAnki Is it ok if I also look for other places where the single or no quotes are used are replace them (everywhere) with double quotes?

MarkWez commented 6 years ago

@AndreiCostinescu Sure, but I think the only other case will be for the initial install of cozmo[camera] - and that's split into separate Mac, Windows and Linux pages so I think they're fine as they are (only the Mac and Linux ones have single quotes in).