Open mikehardy opened 2 years ago
Iw we use workflow_dispatch
+ input: string
, we can avoid having the commit ref in the local.properties
.
Upsides:
Downsides:
I think a requirement is that it has to be fully automated at least within context of a PR, we can't be fishing out the right string to input, and a test commit while waiting until the real version comes out isn't the worst thing - better than manual workflow runs IMHO
Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
I think this has to be in Anki-Android-Backend now that I think about it. Building the backend is a really non-trivial endeavour and it's all set up there. The workflow should pull Anki-Android after the jars are built and run AnkiDroid test / androidTest against the freshly-built artifacts
I feel like this would challenging to implement, as long as the two repos are separate. We get 90% there already by using ./build.sh and testing locally, so perhaps that's enough?
There was an issue that only turned up in Anki-Android (this repo) CI after merging + releasing an Anki-Android-Backend PR and it would be nice to have a workflow that allowed a PR here that was dependent on a PR there to run our CI targets on the PR here against the result of the backend build there
Just some brainstorming:
That would require a final commit in a PR here after launch+release to remove the local.properties but it would still be incremental improvement
...or something