search

ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.11k stars 2.17k forks source link

[Suggestion] Rename "Reviews" on App shortcuts menu more comprehensible name #10728

Closed snowtimeglass closed 2 years ago

snowtimeglass commented 2 years ago

Thank you always, developers.

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

BrayanDSO commented 2 years ago

Rename the item's name more comprehensible one, for example, "Back to Study", "Restart Study", and so on.

I support this. Way more intuitive.

I know Anki uses Review because, after all, the main purpose of the app is to review flashcards. But, I don't have to spend any time to think what Back to study means, while Reviews needs some thought. So, I personally like this change

mikehardy commented 2 years ago

Is "Study" used anywhere? Would "Review cards" or "Open Reviewer" be less ambiguous? I'm not as familiar with the terminology Anki uses in the ecosystem but it would be good to use only words Anki uses normally on desktop

Note that if we change a string and we want fresh translations, there is no clean way to do it without removing the string and re-adding it and all languages lose their current translation. That is worthwhile in some cases but it is a translation cost to keep in mind - if we do this we should do it correctly in other words

BrayanDSO commented 2 years ago

IMO Review cards is fine

mikehardy commented 2 years ago

Okay - glad to hear that - I think it's important to use the exact words Anki Desktop uses as much as possible, for fidelity

I think we could go with that. Do you think it's worth it to push this slight tweak out to all languages and force them to re-translate or is this just an English-string problem? Might employ a sampling strategy on crowdin - pick 3-4 of the most popular languages to see what they did (pt-BR, fr, es) to see if it's worth it

snowtimeglass commented 2 years ago

Is "Study" used anywhere?

I'm not as familiar with the terminology Anki uses in the ecosystem but it would be good to use only words Anki uses normally on desktop

I think it's important to use the exact words Anki Desktop uses as much as possible, for fidelity

The word, "Study", is used on the buttons on Deck overview screen in Anki Desktop, and AnkiDroid respectively. These buttons are used to start showing cards, as the item named "Reviews" on App shortcuts menu is done so. image

As a side note, "Review" is used on the left side of the button on Anki Desktop as a part of the name of three type cards to be shown. image

Would "Review cards" or "Open Reviewer" be less ambiguous?

Considering cases of studying "new" cards (unseen cards), selecting an item named "Review cards" (or "Open Reviewer") seems a bit unnatural. I think that "Study" is an inclusive word to describe checking "new", "learning", and "review" cards. Anki Desktop and AnkiDroid use the word, "Study", to start the check indeed.

Note that if we change a string and we want fresh translations, there is no clean way to do it without removing the string and re-adding it and all languages lose their current translation. That is worthwhile in some cases but it is a translation cost to keep in mind - if we do this we should do it correctly in other words

Yes, I'll keep it in mind, it's very important, but in this case, I think that their current translations aren't lost at least from Crowdin even if the strings are removed from the item, because they probably remain to be used for "Reviews" on Card info. They can be reused if the above alternative solution plan is done.

IMO Review cards is fine

I think we could go with that. Do you think it's worth it to push this slight tweak out to all languages and force them to re-translate or is this just an English-string problem?

To be honest, I think it might be worth to push the change I have suggested above (i.e., "Back to Study", "Restart Study", etc.), not "Review cards", to all languages for the above reasons (For one thing, the word, "Review(s)", seems confusing and unnatural in this case; for another thing, Anki Desktop and AnkiDroid use the word, "Study", to start checking cards), but I'm not a rushing perfectionist who demands perfection in a hurry by using other people's effort and time. I agree that it might still be just a low-priority slight tweak. I would like to know what you developers think about this change. I mean no offense, of course :-)

mikehardy commented 2 years ago

nice screenshot, makes me think 'study now' is right on

BrayanDSO commented 2 years ago

Thanks for the research. Since Anki Desktop uses Study now and I agree it's more natural than Review, I think it's worth the change.

snowtimeglass commented 2 years ago

Thanks for the feedbacks. If you two say so, it'll be good to adopt Study now. I'll vote for it, too :-)

mikehardy commented 2 years ago

Okay - action here is:

That will force new translation for this spot and get the new string in

winstonrc commented 2 years ago

@mikehardy Is this available to work on?

Also, if we simply want it to say "Study", we could use the preexisting studyoptions_start string from 01-core.xml, which naturally matches with the study screen as seen in the screenshot above. Or a new string can be created that says "Study now" if that is indeed the preferred choice.

Niraj81 commented 2 years ago

Can I work on this?

Arthur-Milchior commented 2 years ago

While @winstoncooke asked first, I'd prefer to leave the issue to someone who has not already contributed. Since PR are mandatory to apply to GSoC, I prefer to leave the way to everybody to create one PR, which is hard given our small number of issue.

By the way, @snowtimeglass, I don't know if it's a coincidence that you send us so many issues during the start of GSoC application. But thank you very much, it's extremely appreciated. We are in this very strange situation where we have a lack of bugs, and every single improvement is appreciated in order to let our candidates have at least one contribution.

For the context, studyoptions_start is the button on bottom of "study option fragment", the fragment on the right of the deck picker on tablets. Since it's a button opening an action, I believe that it is probably also acceptable for a shortcut. At least until a translator tell us that they can't use the same word for both places

mikehardy commented 2 years ago

I thought the same thing about the issues @snowtimeglass logged - I thought "wow that's great timing!" - if you have any more send them in!

winstonrc commented 2 years ago

While @winstoncooke asked first, I'd prefer to leave the issue to someone who has not already contributed. Since PR are mandatory to apply to GSoC, I prefer to leave the way to everybody to create one PR, which is hard given our small number of issue.

My only PR so far is removing an erroneous </p> tag in the README, so it's not much! I just submitted a PR but saw @Abhiram-DLVSS has already linked one.

snowtimeglass commented 2 years ago

@Arthur-Milchior, @mikehardy, thank you so much! I'm very pleased to hear that.

I don't know if it's a coincidence that you send us so many issues during the start of GSoC application.

Ah, it's pure coincidence. At first, I was surprised at the current situation and thought "what's on earth going on here!?" And now, I think "what good timing!"

We are in this very strange situation where we have a lack of bugs

Hahaha, wow!

every single improvement is appreciated in order to let our candidates have at least one contribution.

if you have any more send them in!

Sure, with pleasure. I do have them!

snowtimeglass commented 2 years ago

@winstoncooke, thank you for the fix!

winstonrc commented 2 years ago

@snowtimeglass thank you for all your help pointing out issues!

Abhiram-DLVSS commented 2 years ago

I'm closing my pull request (https://github.com/ankidroid/Anki-Android/pull/10759 ) as the alternate pull request is merged.

snowtimeglass commented 2 years ago

@winstoncooke it's my pleasure!

@Abhiram-DLVSS thank you for the PR. I'm sorry about it. I will see you on other issues soon!