ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.59k stars 2.22k forks source link

[Bug] Accessibility issue - Deck overview Number contrast too minimal (2.16b) #13889

Closed MarkusJLechner closed 1 year ago

MarkusJLechner commented 1 year ago
Reproduction Steps

This is new since 2.16 beta. Is it s desired feature or unnoticed change?

  1. Go-to deck overview
  2. Inspect the 3 numbers to the right
Expected Result

The Zeros (0) have a higher contrast to the important numbers new - relearn - review. This is the behavior in version 2.15

(Source Google images, running two versions on phone is not possible) Screenshot_2023-05-18-06-24-16-47_40deb401b9ffe8e1df2f1cc5ba480b12

Actual Result

0s are too bright. As a user, i want to easily see which decks need how many reviews. 0 is no value information. The contrast between light gray and the actual light blue/green/red is too minimal to differentiate. Numbers bigger than 0 are from value, 0 shouldn't be that present. Alternatively using a different character instead of 0 to mark a bigger difference, like a centered dot: • 3 •. However, this is a bigger change to be evaluated.

Screenshot_2023-05-18-06-22-28-58_a9eef3a2a561b80d5c76daebd0f9a14c

Debug info

Refer to the support page if you are unsure where to get the "debug info".

Research

Enter an [x] character to confirm the points below:

SanjaySargam commented 1 year ago

Is it s desired feature or an unnoticed change?

Yes, it's a desired feature, because the zeroes are not adequately visible in dark and black mode. As @Subhadiptech created an issue #12952 against

MarkusJLechner commented 1 year ago

The contract between gray and the other colors is definitely higher in the black theme than the dark theme. It seems that the gray does not adjust to the theme (background).

In issue #12952 I have the same opinion as the issuer, dark gray was nearly not visible at black theme. However I couldn't said that same issue on dark theme before.

The remaining issue is that the "finished" indicator 0 with a brighter color makes the remaining "to be done" numbers harder to disguingish. Since the update, a amount of focus needs to be done on which deck has something else than zeros. Glimpsing through the colors on the right happened to be more difficult since the update. 0 has in this case less value than a number.

snowtimeglass commented 1 year ago

0s are too bright. As a user, i want to easily see which decks need how many reviews. 0 is no value information. The contrast between light gray and the actual light blue/green/red is too minimal to differentiate.

I agree that more faint color for the zero counts would be desirable considering their role. How about re-adjusting the color to some extent, for example as follows. I would appreciate opinions on how others feel about them.

Color comparison of zero counts Same as v2.15.6 (might be too dark) v2.16.2 (might be too bright)
#202020image #808080image
#202020image #808080image
v2.16.2 (might be too bright) Suggestions
#808080image #404040image
#808080image #505050image
snowtimeglass commented 1 year ago
More faint versions black dark
#303030image #404040image
BrayanDSO commented 1 year ago

After giving this a thought, maybe reverting back to the previous color would be okay. The goal of the dimmed numbers is to not call attention, so it doesn't matter if they can't be easily seem

MarkusJLechner commented 1 year ago

More faint versions #303030 | #404040

definitely a big improvement! As i work daily with anki, this would make browsing my 15 "to be done" decks easy again. Since opening the issue i see myself of focusing a lot of time on which deck has something different than 0s, instead of seeing it at a glimpse.

snowtimeglass commented 1 year ago

Thank you for the feedbacks.

maybe reverting back to the previous color would be okay.

I also feel that the reverting might be okay, about the black theme. When viewed on a smartphone device (not on a PC screen), those #202020 0s looks bright enough for me.

However, as for the gray theme, reverting back to the previous color might not be good, because the 0s was darker than the background gray. That might make the 0s a bit stand out, against the intention of not to call attention.

--- ---
Same as v2.15.6 #202020 (might be rather conspicuous with the darkness)image #303030 (invisible other than the case of the selected deck)image
#353535image #383838 (invisible in the selected deck)image
#3C3C3Cimage #404040image
Black theme #202020 (Same as v2.15.6) image Light blue themeimage

It would be desirable to emphasize the contrast with the other fuzzy colors (the background dark gray and other number's pale colors) of that theme, while maintaining consistency with the 0's visibility on the other themes. Considering this balance, #404040 might be better than others for the dark gray theme.

BrayanDSO commented 1 year ago

#404040 looks good to me as well

Subhadiptech commented 1 year ago

Thanks @snowtimeglass for pulling out this issue.