ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.53k stars 2.21k forks source link

[BUG]: Unnecessary "Backup your collection" prompt #13934

Open doozan opened 1 year ago

doozan commented 1 year ago

Checked for duplicates?

What are the steps to reproduce this bug?

Using the default backup and sync settings, I was received the "Backup your collection prompt" even though the most recent backup was 24 hours ago and I had synced the deck even more recently. I'm using the parallel .A build, perhaps it's looking for recent backups in the folder without the .A?

Expected behaviour

No prompt when automatic backups enabled or recently synchronized.

Actual behaviour

Screenshot_20230531-120356_AnkiDroidA

Recent backups: Screenshot_20230601-075216_AnkiDroidA

Backup settings: Screenshot_20230601-075334_AnkiDroidA

Debug info

AnkiDroid Version = 2.16.0beta2

Android Version = 12

ProductFlavor = full

Manufacturer = samsung

Model = SM-G970U

Hardware = qcom

Webview User Agent = Mozilla/5.0 (Linux; Android 12; SM-G970U Build/SP1A.210812.016; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/106.0.5249.126 Mobile Safari/537.36

ACRA UUID = 0819f67d-4836-45b6-90c6-ecc700511215

New schema = true

Scheduler = std3

Crash Reports Enabled = true

DatabaseV2 Enabled = true

(Optional) Anything else you want to share?

No response

Research

BrayanDSO commented 1 year ago

This means an external backup that won't be deleted in case you uninstall the app. The ones present on your screenshot are deleted as well on that situation. Currently, the only options are to sync or to export the collection to an external backup

doozan commented 1 year ago

Thank you for the explanation, that makes sense with the backup files. But this message shouldn't appear if I sync regularly, right? Since the buttons are "Later" and "Sync" and not "Later" and "Create an external backup now", it implies that a "sync" counts as a "backup" and since I've sync'd recently it shouldn't be asking me to sync again.

BrayanDSO commented 1 year ago

Most likely a bug. Open to investigation

pavreh commented 1 year ago

"Backup your collection" prompt appeared when I opened AnkiDroid (2.16.0beta5) after few days. Automatic backups were enabled and the collection was synced at the background of the "Backup your collection" prompt. So I agree the prompt should not appear when automatic backups are enabled.

github-actions[bot] commented 11 months ago

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

david-allison commented 11 months ago

Automatic Backups Automatic (non-synced) backups are wiped if the user uninstalls/deletes app data AND is running from the Play Store

Using SAF for 'safe' backups was deferred from 2.16 and nobody has taken on this task.

Synced Backups Automatic synchronisation is likely not the exact primitive to use to determine if we show the dialog: if a user is on a metered connection, then even with the setting enabled, automatic synchronisation would not occur

We do want to avoid showing this if an automatic synchronisation attempt is in progress

x51mon commented 11 months ago

I think the dialog, as it is now without additional explanation and the options later and sync, is quite confusing. Had to come here to understand why I'm seeing it and I'm using Anki for a bit now.

Personally I'd like an option to turn it off. I regularly sync and have backups on desktop, so I mostly need the backups on AnkiDroid if changes are lost in a Sync. It's good to know though that the backups are lost if the app is uninstalled.

Self-Perfection commented 5 months ago

I occasionally get "Backup your collection" dialog with AnkiDroid 2.17.6

This dialog is confusing and I don't understand what is going on even after reading comments here.

For me it just an annoyance. As I sync daily with Anki servers and have backups at desktop Anki, I think I am quite safe with my collections and don't need extra reminders.