ankidroid / Anki-Android

AnkiDroid: Anki flashcards on Android. Your secret trick to achieve superhuman information retention.
GNU General Public License v3.0
8.2k stars 2.17k forks source link

[BUG]: Undo Delete Snackbar Doesn't Appear #14298

Open brishtibheja opened 11 months ago

brishtibheja commented 11 months ago

Checked for duplicates?

What are the steps to reproduce this bug?

  1. Open card browser
  2. Search is:new(a snackbar appears here saying [number of cards] cards shown)
  3. Select a card
  4. Press Delete(a second snackbar should appear)

Expected behaviour

Snackbar for deletion should appear.

Actual behaviour

It doesn't unless the previous snackbar has disappeared.

Debug info

AnkiDroid Version = 2.16.3

Android Version = 11

ProductFlavor = full

Manufacturer = realme

Model = RMX2193

Hardware = mt6768

Webview User Agent = Mozilla/5.0 (Linux; Android 11; RMX2193 Build/RP1A.200720.011; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/115.0.5790.166 Mobile Safari/537.36

ACRA UUID = dce906d5-19f7-4514-a0e4-0071f4f7b489

New schema = false

Scheduler = std2

Crash Reports Enabled = true

DatabaseV2 Enabled = true

(Optional) Anything else you want to share?

In my opinion the snackbar should be replaced by a bin feature. I've raised this here #14227 But it seems Improbable unless anki desktop implements a similar feature. But anyways, thanks to all the devs for their amazing work!

Research

criticalAY commented 11 months ago

I would look into it and fix it

brishtibheja commented 10 months ago

@david-allison Hey, I'll just add that even if the first snackbar disappears the issue still remains. Everytime you delete something search result snackbar would hide the card deleted snack bar. I originally said the issue only stays until the first snackbar has disappeared but that's not true.

criticalAY commented 10 months ago

yes I have fixed that, can see the video in the PR

brishtibheja commented 7 months ago

As a temporary measure can the delete notes option not ask for a confirmation before deleting something? Just to make sure in the meantime nobody ends up deleting something accidently?

david-allison commented 7 months ago

Isn't "Undo" still available in the overflow menu?

brishtibheja commented 7 months ago

Oh yes it is. I didn't thought of that tbh. My immediate reaction to pressing delete is quickly close app and clear cache, then to come back while praying nothing happened lol.

david-allison commented 7 months ago

Clearing cache won't help, it's already saved to the database and we don't use the cache for much

Restoring from backup would be the way to go if you've closed the app

david-allison commented 7 months ago

Just to be clear: I want this fixed, and I'm in the middle of a large project to improve the browser, but it'll take time to get to on my priority list

We've got a lot of pressure/work to get 2.17 out: there's been a huge change in using the experimental backend, which means there's a lot of stability work required, but it also enables the FSRS scheduler. This is taking priority for now

github-actions[bot] commented 4 months ago

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

criticalAY commented 4 months ago

@david-allison please keep open